Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9830b94a-da88-48f2-6fcd-da46b2e2ed0a@oracle.com>
Date:   Thu, 20 Jul 2023 12:43:35 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
To:     scott@os.amperecomputing.com
Cc:     catalin.marinas@arm.com, darren@os.amperecomputing.com,
        james.morse@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, will@kernel.org
References: <20230627002939.2758-1-scott@os.amperecomputing.com>
Subject: Re: [PATCH v6] arm64: sdei: abort running SDEI handlers during crash
Content-Language: ro
From:   Mihai Carabas <mihai.carabas@oracle.com>
In-Reply-To: <20230627002939.2758-1-scott@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blZWSmhPNzEzdjk4cER1VkNaVTFjSkFpNGxSZVRTdlgyU2ExeXpITGFBelAw?=
 =?utf-8?B?TUlIbFYzYmdYVENSZXJPcmltK1FrU0RtSHIzQXhLQ3BkaVQwck1OU05hWkNL?=
 =?utf-8?B?OVpKYTFqeEltenBtNnpNajA0OEJCRlZjWmFrRmc5QWd4L0ZYdFUvdHNka2gx?=
 =?utf-8?B?anVNTlFtRWN2N0lQcGQxQkxUa2pZQTdxblNjNFhGZStiMkIwV2svaUlHYWtY?=
 =?utf-8?B?dWJ4ZGVEeDlHVnhXMmx2SmpaY3hOanRrRHNVckhyQTB1UVhjaVpLRVJiWkVO?=
 =?utf-8?B?SHFQQzZmQ28wWHNNWjdJcEJIbHpkd2l2RWVld1hlRHp6Q1haOEh1NmpQUmFk?=
 =?utf-8?B?Qk91TUVzUXdaNVl2aGdhVEcwS3hBU3lTOUxSUEtUL3hpS0hTdTFyb2thaDNh?=
 =?utf-8?B?WHRjTUthRGtEbVd3L3RUN0VGVFB1OXl6ZE80MjBlQkZNNDRJbkFINEJPWjNM?=
 =?utf-8?B?MkZIRTBDa0VlcS82NWNsSUczSWVGMVFmSEgrZzVTSnpRNDlrTHNQaG9keHE3?=
 =?utf-8?B?SEpjL3BHc3FvbUR1Ylo1ZVNQcWRocCs4RG12N0E5S1VCLytINzRhbnZxZ2lP?=
 =?utf-8?B?N0VJSWtCWHBxc3hIV0RVUWVaSEFSSU9yUmJFWDFSeDNnMERDd003SFlLMzdM?=
 =?utf-8?B?amZWb01mTnplbnZiTGpDQVRhUkhrQ0YrUXJKdWl2ZmlpZ25vVjRFZWliQ3Rp?=
 =?utf-8?B?MG1QVVZlczVkN3I4c1UvM1U4a08zYi81MEpUcUV3UXE1L3ZNS3dGRkdXUEtr?=
 =?utf-8?B?YmpQYWxNUjM3K1kxemYyekVOVjlzNVpCWFYxcElNc09pRlhxY25wV0FiRGhW?=
 =?utf-8?B?Y0oyK2hmMlRBUXk3dk1lVzZnaTk4ZXdBbjBJN2NCbDJCVUFCZ0VJZWNtVTJj?=
 =?utf-8?B?UGRSbWxXZjQwMGFST1lWSi9tUEtrekZQVG5ITU1VeTZDRHFycEhKWldreWRK?=
 =?utf-8?B?N05sQzhQQ1ROeEsySHJlaVJ0Mi9SQS8yNkVjamhDeUNFUVZUcGRmY29BdUg2?=
 =?utf-8?B?eHBEL3JwUm9hZ29vSXM5dHdyYVJFUHZ0d2RpUmhyRmtxaWgvUGo1L0FEMWVo?=
 =?utf-8?B?MDN5MEFlbk9hWktxNHlHWW5YbFd1MHozNURTU0VncmN2R3lXNkI2N0dsWDlj?=
 =?utf-8?B?eTNvaFhhZndRTERQU3FpOFdtdjRXcFYwVFMzdVpBUkwwOTliSW9SWDhHdGxM?=
 =?utf-8?B?d3BCd3dHb2RtSWR2SWZFRHdQVnJBdzVZL2xCMmdVVzlCcU1mMkZuU1NPeGhM?=
 =?utf-8?B?YVJ3UzN6R1JKQnpQbzhIT0d1bHk3UmsyaHdORFc1cVZKNGRVVHBxS2VtaE0v?=
 =?utf-8?B?eVdwVHpoWk5qNVlYQ282ZGwrNHRsSk1oNkFKY0dHOWZkL3Fjc1pQazNTcmls?=
 =?utf-8?B?Zyt4aXRmT2ZCVkNkMlQ1Z3JFKzYrSGNQZTJ0b2NIazF3U1Bpc1VtR0EzMVlQ?=
 =?utf-8?B?UEFjNUNRSldHaHMvcFBydTJ2dEFCNEV6ZTZpNVVDQmtKOUo2ODN0M05VTjlN?=
 =?utf-8?B?dmlpUEVWL3RkL3cvTSt2NnU2OXBiaCtldkhYeWpWMjh5TnVVSlJEQUpBZkZ0?=
 =?utf-8?B?dCs5aTdUOVZUaDFVWW93ZUxPTU1kUHZGRUpGVVdpVGRTeFdqRDltdlpqRnYz?=
 =?utf-8?B?UnAvTUtoOThsMjRvMzZCdDI4RlpnSXY5RWtVYW1UeTZzQmRJV294dEJjemQ2?=
 =?utf-8?B?TVlUT3k1Nk1NQXVmTUoxeWlTN2RITFMrZnJxOHZWVUZMazZLU3J0S1pBQXh3?=
 =?utf-8?B?WEZNemxJeVg1bnVZZ3YxUUhiNmM3S3pBeVZ0SDJiOGNSSWxGTnZ6OFA5bktx?=
 =?utf-8?B?Tjd6QVVzZ2pVUWQ0cjhHS3lTbmJ5eHRRNmh5Q3FIb3VGN0JuaU1TR3U2TTBO?=
 =?utf-8?B?WDlSWkZaRmRBVnJXNWxPNFBHZDNjTWZKTHordUt2MGJ2M2hXR3JTeVRjSk9F?=
 =?utf-8?B?Ly9PWDAveVBDbm9UZWF1RmpXVjQ5YXlxRkpUT2phRmxieWI4N3AzUEFWbWkr?=
 =?utf-8?B?RVRjY0FybllRWm5GK1JYRi9BQ0I1a2V2YXlEWEhkbDhRczREK3VPdnVBK0JG?=
 =?utf-8?B?WU9YMXdyaDFtQ1BLVkNvMmhyUE1PZFhHSmhQc2V4THVuQzF0VG0xVEpVK213?=
 =?utf-8?B?Q1hUbjVCclRCNEZTYlhZVHlScktYc09tS3pWQ3p4UDBDQjVOcG11Z0xwbXBu?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Mnuipe8OJ/nAzVagqbSRn0+o2B6GRBYX75+3iShMiY26YJvzYj2bL2XuQqGri4JbIqgCAHYYHbNj3cxx4Q0T9YWz8pSUHSBOKzPgjLPPWzdM0NsIVSIBjmR2IZZkj9W3emJLW2mhiEJKdaJYuu3tF/JKQ8Q28YcDXmbjWfztVVkhNBzdPG18tlTf1NpRH8esh9n4Qi5Ex02HPcMhn/GbDq/XzwAOOAhRyHYrBLaDzQbOgNQmrWqorLm0ylHNN89aVFcO3Q56VlkBLe0RjShm06lk9qHcFqBFVaqM434rFG64bMEzCkcPfGFtKZDvx5+UJGeZ6agtUPVR0CK4DprmU08qyVNu7XGjKAqDWi8pss7hTyCKJ95pMdbeCtNnbhxrctfLhpoBog/27Zp50oaIqy8eA9AKAVGEV9Zg3q38kMG06GfV4HmuOhQaysz6uXquA6IXDzpHrUepb7HZvsqSvjX/GV0DYNjOcF/cpuBaJoclz4GoMJkgwmKiBpvMxZOz99SVp67OSc+dRYUA94D5EMYrS2WlZPnyfP2pU8NmPwzRA5wdO6Lcnbpxxq9c447gSaZFozBZCUTrQmvFGqJ47PQPySU8HEavXeoErdd1Q0U4ILaciiERKOj5y7ufT8dyzUvREQPi9JiavXDC/HQWmjRJcfMHpBexLze8PzNoJRU8JXGIeWFvuxjCQOcjaQreZH8S+bhGCTpkMM0ZV1b+/thiVYsXRiredHnohGSt8QG4JPyGXW4je6dbfxjZMq40yLHghqn+uGHhv9eQk+2RIN6Kk03EQ1QJd8n3gmA9QI3LNfOijTkZfs9u2wDAHoNGBLUdsgqSI4A+2CFxPuJs9cSnWuPydRKQHzpeP1V874Qw6xMV1XmsTIuHdgkjk4G+EMV3Mddj+6OLssCnwdSLnEdf5fdUqeKvoAhzwVfnp20=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80986982-0baa-4f50-81dc-08db8905cc9c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5894.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:43:40.5242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6xSxQ6ZPaTmlRHSyQL1fXOyTSLYhyy6KA700zRnwo3KptsYfGfSJD49p5k73qg3Qc1zikPMze9TTq8BfUC+kekSGjHcmNrATtL+xe/GUo5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7975
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-20_03,2023-07-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=831
 suspectscore=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307200081
X-Proofpoint-ORIG-GUID: 5K6j6z5qTUjnfxIJd6qqdp4qMy6o6COw
X-Proofpoint-GUID: 5K6j6z5qTUjnfxIJd6qqdp4qMy6o6COw
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 > Interrupts are blocked in SDEI context, per the SDEI spec: "The client
 > interrupts cannot preempt the event handler." If we crashed in the SDEI
 > handler-running context (as with ACPI's AGDI) then we need to clean 
up the
 > SDEI state before proceeding to the crash kernel so that the crash kernel
 > can have working interrupts.
 >
 > Track the active SDEI handler per-cpu so that we can COMPLETE_AND_RESUME
 > the handler, discarding the interrupted context.

 > Fixes: f5df26961853 ("arm64: kernel: Add arch-specific SDEI entry 
code and CPU masking")
 > Signed-off-by: D Scott Phillips <scott@os.amperecomputing.com>

We have tested successfully this patch on Altra and AmpereOne.

Tested-by: Mihai Carabas <mihai.carabas@oracle.com>