Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8194aa14-6465-5b4d-1b13-72c6af818f82@quicinc.com>
Date:   Thu, 20 Jul 2023 15:25:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V4] PCI: qcom: Fixing broken pcie bring up for 2_3_3
 configs ops
Content-Language: en-US
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC:     Greg KH <gregkh@linuxfoundation.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh@kernel.org>, <mani@kernel.org>, <lpieralisi@kernel.org>,
        <bhelgaas@google.com>, <kw@linux.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <stable@vger.kernel.org>
References: <20230717065535.2065582-1-quic_srichara@quicinc.com>
 <2023071729-shamrock-evidence-b698@gregkh>
 <2fc238aa-82c1-383a-9dca-72f979ee3c07@quicinc.com>
 <CAA8EJpoB6Q5c27-D5HF42+OS7S7bPBGWi_Po0orMxaQ7yx3=1A@mail.gmail.com>
From:   Sricharan Ramabadhran <quic_srichara@quicinc.com>
In-Reply-To: <CAA8EJpoB6Q5c27-D5HF42+OS7S7bPBGWi_Po0orMxaQ7yx3=1A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/17/2023 11:23 PM, Dmitry Baryshkov wrote:
> On Mon, 17 Jul 2023 at 20:16, Sricharan Ramabadhran
> <quic_srichara@quicinc.com> wrote:
>>
>>
>>
>> On 7/17/2023 7:09 PM, Greg KH wrote:
>>> On Mon, Jul 17, 2023 at 12:25:35PM +0530, Sricharan Ramabadhran wrote:
>>>> PARF_SLV_ADDR_SPACE_SIZE_2_3_3 macro is used for IPQ8074
>>>> 2_3_3 post_init ops. PCIe slave addr size was initially set
>>>> to 0x358, but was wrongly changed to 0x168 as a part of
>>>> commit 39171b33f652 ("PCI: qcom: Remove PCIE20_ prefix from
>>>> register definitions"). Fixing it, by using the right macro
>>>> PARF_SLV_ADDR_SPACE_SIZE and remove the unused
>>>> PARF_SLV_ADDR_SPACE_SIZE_2_3_3.
>>>
>>> Note, you do have a full 72 columns to use, no need to make it smaller.
>>
>>    ok sure
>>
>>>
>>>> Without this pcie bring up on IPQ8074 is broken now.
>>>
>>> I do not understand, something that used to work now breaks, or this is
>>> preventing a new chip from being "brought up"?
>>>
>>
>>    yes, ipq8074 pcie which was previously working is broken now.
>>    This patch fixes it.
> 
> So, you need to describe what is broken and why. Mere "it is broken,
> fix it" is not enough.

  ok sure, will change the subject and explicitly state in commit log
  how pcie enumeration is broken up.


Regards,
  Sricharan