Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a989179a-102a-d07d-aa80-0ff45d21a74a@huawei.com>
Date:   Thu, 20 Jul 2023 17:31:48 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
From:   "zhangpeng (AS)" <zhangpeng362@huawei.com>
Subject: Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to
 take in a folio
To:     Matthew Wilcox <willy@infradead.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <sidhartha.kumar@oracle.com>, <akpm@linux-foundation.org>,
        <wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>
References: <20230719095848.3422629-1-zhangpeng362@huawei.com>
 <20230719095848.3422629-9-zhangpeng362@huawei.com>
 <ZLfyDvSgFxkX6Z1Z@casper.infradead.org>
Content-Language: en-US
In-Reply-To: <ZLfyDvSgFxkX6Z1Z@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/19 22:24, Matthew Wilcox wrote:

> On Wed, Jul 19, 2023 at 05:58:47PM +0800, Peng Zhang wrote:
>> -static inline void count_swpout_vm_event(struct page *page)
>> +static inline void count_swpout_vm_event(struct folio *folio)
>>   {
>>   #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> -	if (unlikely(PageTransHuge(page)))
>> +	if (unlikely(folio_test_pmd_mappable(folio)))
>>   		count_vm_event(THP_SWPOUT);
>>   #endif
> As I said in my earlier response, you don't need the ifdefs.  Check
> the definition of folio_test_pmd_mappable.

Sorry I forgot to delete the ifdefs. I'll fix it in a v3.
Thanks.

-- 
Best Regards,
Peng