Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47eb92888fa46315214ad921a9ac45b695355a36.camel@redhat.com>
Subject: Re: [PATCH net v4] bonding: Fix error checking for
 debugfs_create_dir()
From:   Paolo Abeni <pabeni@redhat.com>
To:     =?UTF-8?Q?=E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=BA=95=E5=B1=82?=
         =?UTF-8?Q?=E6=8A=80=E6=9C=AF=E9=83=A8?= <machel@vivo.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Taku Izumi <izumi.taku@jp.fujitsu.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     "opensource.kernel" <opensource.kernel@vivo.com>,
        "ttoukan.linux@gmail.com" <ttoukan.linux@gmail.com>,
        "jay.vosburgh@canonical.com" <jay.vosburgh@canonical.com>
Date:   Thu, 20 Jul 2023 12:20:01 +0200
In-Reply-To: <20230719020822.541-1-machel@vivo.com>
References: <20230719020822.541-1-machel@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-07-19 at 02:10 +0000, =E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=
=BA=95=E5=B1=82=E6=8A=80=E6=9C=AF=E9=83=A8 wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
>=20
> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding dr=
iver")
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
>  drivers/net/bonding/bond_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bon=
d_debugfs.c
> index 594094526648..d4a82f276e87 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>  {
>  	bonding_debug_root =3D debugfs_create_dir("bonding", NULL);
> =20
> -	if (!bonding_debug_root)
> +	if (IS_ERR(bonding_debug_root))
>  		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>  }
> =20

Does not apply cleanly to -net. To be more accurate, the patch is
base64 encoded and git is quite unhappy to decode it.

Possibly your mail server is doing something funny in between?!?

Please solve the above before reposting.

/P