Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <267e7d8d-887e-99e8-f367-f6b614a721fb@quicinc.com>
Date:   Thu, 20 Jul 2023 16:46:04 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add support for the RDP415
 variant
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
        <quic_kathirav@quicinc.com>, <quic_arajkuma@quicinc.com>,
        <quic_anusha@quicinc.com>
References: <20230720074846.20350-1-quic_harihk@quicinc.com>
 <20230720074846.20350-3-quic_harihk@quicinc.com>
 <6f26ab9d-cf92-e918-866c-daa68096ee08@linaro.org>
From:   Hariharan K <quic_harihk@quicinc.com>
In-Reply-To: <6f26ab9d-cf92-e918-866c-daa68096ee08@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/20/2023 1:46 PM, Konrad Dybcio wrote:
> On 20.07.2023 09:48, Hariharan K wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 415 based on IPQ5018 family of SoC. This patch
>> carries the support for Console UART and eMMC.
>>
>> Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
>> ---
> [...]
> 
>> +
>> +&sdhc_1 {
>> +	pinctrl-0 = <&sdc_default_state>;
>> +	pinctrl-names = "default";
>> +	mmc-ddr-1_8v;
>> +	mmc-hs200-1_8v;
>> +	max-frequency = <192000000>;
>> +	bus-width = <4>;
>> +	status = "okay";
> Since some (but presumably not all) SKUs have SDHCI, you can define
> the plumbing for it in the common DTSI but only enable it on ones
> that do (or disable on those that don't)

Sure. Will update in the next version.

Best regards,
Hariharan K

> 
> Konrad