Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609120636.3969045-1-arnd@kernel.org> <b3a3e2f8-51d8-f8ce-95ce-1180f80cc2d2@habana.ai>
 <CAFCwf122kE8sNksXivPA+E=BWzjroKowwqDJrHVMNj-o3oJq0A@mail.gmail.com> <ZLkMjL8Aebipv4QR@phenom.ffwll.local>
In-Reply-To: <ZLkMjL8Aebipv4QR@phenom.ffwll.local>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 20 Jul 2023 13:36:52 +0300
Message-ID: <CAFCwf12Mot6LmoKF=5okXokKWRanCoxqRPbJV34EwL8__bcHfA@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
To:     Oded Gabbay <ogabbay@kernel.org>, Tomer Tayar <ttayar@habana.ai>,
        Arnd Bergmann <arnd@kernel.org>,
        Ohad Sharabi <osharabi@habana.ai>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Dafna Hirschfeld <dhirschfeld@habana.ai>,
        Ofir Bitton <obitton@habana.ai>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 20, 2023 at 1:29=E2=80=AFPM Daniel Vetter <daniel@ffwll.ch> wro=
te:
>
> On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote:
> > On Fri, Jun 9, 2023 at 4:37=E2=80=AFPM Tomer Tayar <ttayar@habana.ai> w=
rote:
> > >
> > > On 09/06/2023 15:06, Arnd Bergmann wrote:
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > Two functions got added with normal prototypes for debugfs, but not
> > > > alternative when building without it:
> > > >
> > > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_in=
it':
> > > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit d=
eclaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_i=
nit'? [-Werror=3Dimplicit-function-declaration]
> > > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit de=
claration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_re=
move_file'? [-Werror=3Dimplicit-function-declaration]
> > > >
> > > > Add stubs for these as well.
> > > >
> > > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later=
")
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > Thanks,
> > > Reviewed-by: Tomer Tayar <ttayar@habana.ai>
> >
> > Thanks,
> > Applied to -fixes.
>
> As requested applied to drm-fixes, hopeful for the next one your drm-misc
> account issue is fixed.
> -Daniel

Thanks Daniel for the help.
I also hope it will be fixed :)
Oded

>
> > Oded
> > >
> > > > ---
> > > >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > > >   1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers=
/accel/habanalabs/common/habanalabs.h
> > > > index d92ba2e30e310..2f027d5a82064 100644
> > > > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > > > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > > >   {
> > > >   }
> > > >
> > > > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > > > +{
> > > > +     return 0;
> > > > +}
> > > > +
> > > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > > > +{
> > > > +}
> > > > +
> > > >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > > >   {
> > > >   }
> > >
> > >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch