Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9472394rwp; Thu, 20 Jul 2023 05:36:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlFmuqzrzgj+mTCkdSZepR3Xlk5B3duMmFA+4Z6cHI/L6JoHELuWRa5V6f1PFsDXEEsmSHZt X-Received: by 2002:a9d:4d02:0:b0:6b8:7d12:423d with SMTP id n2-20020a9d4d02000000b006b87d12423dmr1943246otf.18.1689856605358; Thu, 20 Jul 2023 05:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689856605; cv=none; d=google.com; s=arc-20160816; b=k98AkyaXHgZhro0ZjkoJbNY4vTWPkR+MSCDMkLHpYMdPu1nr6UtiwcIT2gdcaa/Sh0 Npj5kqOfo1EkQHkZKINRkzdak/y220YsQO77rMf12YO+HlC4ATJT544rlyeE3e6OEg3F nLspRZXS0rxfFU790ybg4f4GbjoxXwNvTnMu9BuNuvrvkNzpIkRIq2huzyy4uy+BTFYl 2pi5AcKeftKCYoHXgmP4HGhwqCwahjHHkh+rWuxx2B9tfj7/Rl1uHfj0Tz/ZPbSS2D3q 9AUvVkHdy78d3cJboynPtC4qAA2mAECQUpjSa0I6lvhldFN2ZJMfSs1c8jT1OL3Q9wIa 9Y2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rCw+psKLDBdl6kAXIJPY9IcEhZY5IxhHwvg4KUYy27Q=; fh=tJPLVoLGJ4YBYZ8STWeX10rYj6Viax9HhHg0Jk7CppA=; b=NLxZKV4CYPt5Vx/oMcjJEXloSnj8O0Supf0+YheyfXABE4puOpP915CUU9qs/FQmCj Pw16w91JSI7AokHiJP+hDWc2AggC6b6TbHflQbr9oSgCf1GcWV+xoQRxw2uI3JaTm90+ JMZzpdHLYJ1wFbNeUtYcBLRJ0Llgypj6BovoGgyuRUdUYOio89UksKa6hnGGl9Sx8jLK KNROJmW0F1igjJafu/oT/MHeJGgRyJiclRtqfYZLi90pVmLtTSwyIJHKYroUehVXcExV gQ3vJqR5SLlenwAW3Ffgh3O5EfFf7b2pRUE4oEkMAU3/ZhQGRnPX3VRZn3TPohOgFZWe 7Wqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwiRNKVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a73-20020a63904c000000b0055fc5fdd135si718089pge.746.2023.07.20.05.36.32; Thu, 20 Jul 2023 05:36:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwiRNKVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbjGTM1V (ORCPT + 99 others); Thu, 20 Jul 2023 08:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbjGTM1T (ORCPT ); Thu, 20 Jul 2023 08:27:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EE1F2118; Thu, 20 Jul 2023 05:27:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABB0F618F6; Thu, 20 Jul 2023 12:27:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB6CAC433C8; Thu, 20 Jul 2023 12:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689856036; bh=rCw+psKLDBdl6kAXIJPY9IcEhZY5IxhHwvg4KUYy27Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BwiRNKVJdr15gmyYf87c5qkAeJKVgK0bUhpYNBH1JoM8PiqO/jE0lKC7Dha56w0BT 7O/vwi9WBffNUurAE/FZjy7XJUz2CFkFxvVB7vCi6Ru6h6KIU083RJOIryIfENkD1X oTENDWIdJqSXUAPOfCcYOIf/NGXgzL/80xC+2m1uOmTieNUgd9F7ACJib/Zssmi7kJ h8IWNcPMAhii51lmlhTmMjHATZ9KWJgeQ7ghBT/98FD0E6coqekAxPi+iTbkKn/6IH LI7B5Qlh4ewNKw5JkkAM1YGH45chzb7Sy41C856SadZ3c4y6onctYse05VbAblsj7m JvR4b6hrEFSTA== Date: Thu, 20 Jul 2023 13:27:10 +0100 From: Mark Brown To: Will Deacon Cc: Catalin Marinas , Shuah Khan , David Spickett , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] arm64/fpsimd: Ensure SME storage is allocated after SVE VL changes Message-ID: <3ce4fc14-bd43-47e9-aa37-59bb3cd5d051@sirena.org.uk> References: <20230713-arm64-fix-sve-sme-vl-change-v1-0-129dd8611413@kernel.org> <20230713-arm64-fix-sve-sme-vl-change-v1-1-129dd8611413@kernel.org> <20230720105235.GD11034@willie-the-truck> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CyMXBdFoH12etnuE" Content-Disposition: inline In-Reply-To: <20230720105235.GD11034@willie-the-truck> X-Cookie: Ginger snap. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CyMXBdFoH12etnuE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 20, 2023 at 11:52:36AM +0100, Will Deacon wrote: > On Thu, Jul 13, 2023 at 09:06:04PM +0100, Mark Brown wrote: > > Since the ABI does not specify that changing the SVE vector length disturbs > > SME state, and since SVE code may not be aware of SME code in the process, > > we shouldn't simply discard any ZA state. Instead immediately reallocate > > the storage for SVE if SME is active, and disable SME if we change the SVE > > vector length while there is no SME state active. > What is the advantage of keep the old behaviour in this case? In other > words, if it's acceptable to reallocate the state when SME is active, why > not just reallocate in all cases? It was minimising the changes to the status quo given how attached people often are to these things. --CyMXBdFoH12etnuE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS5KB4ACgkQJNaLcl1U h9C+0gf/fQxZuh51kIYByTPW3QLeYr1gzvXo8eFWKQxVOYg96BpcLaqbrocw6ZLg E0VA1/CrGB56VUq99z4VY0JUrqFoupiFJE5M5MihIAUi/0PPH9LsvzvuXuIAnrK4 CmqsOfSQTbsXhntG34dq3UkcK7VZlbK4iSZsaKig3BLtIWHBVJ1WvLpnxEkVu0Mv +qJM4GDgPeIXRKiMcxT6+Gd96Vza5VFUemOFSO9BGW5XzQE7Ix+NpT99XvE0MtwJ mTVS7V3g0F+19U08hExwfgrKS1ybUONPOqncDhwLdghsLFFOeW8WI1ttxw26afX8 UO1YvtblScSAt6Aex+N4yBujBbHMaA== =NOme -----END PGP SIGNATURE----- --CyMXBdFoH12etnuE--