Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 08:55:01 -0500
From:   Nishanth Menon <nm@ti.com>
To:     <sunran001@208suo.com>
CC:     <kristo@kernel.org>, <ssantosh@kernel.org>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: keystone: sci-clk: fix application of sizeof to
 pointer
Message-ID: <20230720135501.uxjb4oyn26ztmngv@bonelike>
References: <20230720074906.3373-1-xujianghui@cdjrlc.com>
 <3ad9c41575c274137001916c896bf2b6@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3ad9c41575c274137001916c896bf2b6@208suo.com>
Precedence: bulk

On 16:42-20230720, sunran001@208suo.com wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
> sizeof to pointer

-ECONFUSED -> the report does'nt match the file here. did I miss
something?
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/clk/keystone/sci-clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c
> index 6c1df4f11536..2c68c1e09d1f 100644
> --- a/drivers/clk/keystone/sci-clk.c
> +++ b/drivers/clk/keystone/sci-clk.c
> @@ -389,7 +389,7 @@ static struct clk_hw *sci_clk_get(struct of_phandle_args
> *clkspec, void *data)
>  	key.clk_id = clkspec->args[1];
> 
>  	clk = bsearch(&key, provider->clocks, provider->num_clocks,
> -		      sizeof(clk), _cmp_sci_clk);
> +		      sizeof(**clk), _cmp_sci_clk);
> 
>  	if (!clk)
>  		return ERR_PTR(-ENODEV);

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D