Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 15:11:04 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Subject: Re: [PATCH v1 01/11] ALSA: cs35l41: Use mbox command to enable
 speaker output for external boost
Message-ID: <56e50829-b93d-48ef-9691-5c78229a4b5c@sirena.org.uk>
References: <20230720133147.1294337-1-sbinding@opensource.cirrus.com>
 <20230720133147.1294337-2-sbinding@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6K/jTXohBWi27Iqj"
Content-Disposition: inline
In-Reply-To: <20230720133147.1294337-2-sbinding@opensource.cirrus.com>
Precedence: bulk


--6K/jTXohBWi27Iqj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 20, 2023 at 02:31:37PM +0100, Stefan Binding wrote:
> To enable the speaker output in external boost mode, 2 registers must
> be set, one after another. The longer the time between the writes of
> the two registers, the more likely, and more loudly a pop may occur.
> To minimize this, an mbox command can be used to allow the firmware
> to perform this action, minimizing any delay between write, thus
> minimizing any pop or click as a result. The old method will remain
> when running without firmware.

> In addition, to ensure the chip has correctly powered up or down,
> the driver will now poll a register, rather than wait a fixed delay.

That should probably be a separate patch.

Acked-by: Mark Brown <broonie@kernel.org>

--6K/jTXohBWi27Iqj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS5QHcACgkQJNaLcl1U
h9CSggf/fWKATarmWnlKrAg5ClZia9/eeWSg0KKHc06sQbmmP/KEhtCBpkvFTBOP
I15i7IhT3RoZgCuxf7TnbYKKJa5kfk38EIjVALr8tFA2JdhZduFP8uT25kcAoeMO
G6o5abKdyupUKaB0Aw40lDDZ125HszaGVkN7iz/xDGTdtnPnpvhL1Py6r9jBbxDk
YdOAxE0V3shZLMfpeKa1zPjlS/yg0PF+jIuYW/nb3Ebp8GuNaF5bSxI1Zqaq9u4s
7ecg09LG+cVWG2DcrJ2O559FEQ0Apvx3bvVBDX2vG0ZuO7tDPFgrZrfKpmXnGW56
RWZlhomLpsJYb82MQVGLNzSLd7gIng==
=b/2M
-----END PGP SIGNATURE-----

--6K/jTXohBWi27Iqj--