Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760070AbXJZMdX (ORCPT ); Fri, 26 Oct 2007 08:33:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752343AbXJZMdR (ORCPT ); Fri, 26 Oct 2007 08:33:17 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:60420 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbXJZMdQ (ORCPT ); Fri, 26 Oct 2007 08:33:16 -0400 Date: Fri, 26 Oct 2007 14:33:15 +0200 (CEST) From: Jan Engelhardt To: Hugh Dickins cc: Jiri Kosina , Andrew Morton , Sami Farin , Linux kernel Mailing List , Jiri Kosina , Arjan van de Ven Subject: Re: [PATCH] [RFC] brk randomization: compute RLIMIT_DATA properly (was Re: x86: randomize brk() and RLIMIT_DATA) In-Reply-To: Message-ID: References: <20071025134124.wc44gdud7ixghfxv@m.safari.iki.fi> <20071025071324.2eac21d6@laptopd505.fenrus.org> <20071025171942.pjff7jbpempfcuri@m.safari.iki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 20 On Oct 26 2007 13:30, Hugh Dickins wrote: >> @@ -251,7 +251,8 @@ asmlinkage unsigned long sys_brk(unsigned long brk) >> * not page aligned -Ram Gupta >> */ >> rlim = current->signal->rlim[RLIMIT_DATA].rlim_cur; >> - if (rlim < RLIM_INFINITY && brk - mm->start_data > rlim) >> + if (rlim < RLIM_INFINITY && (brk - mm->start_brk) + >> + (mm->end_data - mm->start_data) > rlim) >> goto out; >> >> newbrk = PAGE_ALIGN(brk); Parentheses around (brk - mm->start_brk) + (mm->end_data - mm->start_data) not strictly necessary. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/