Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 17:00:17 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     William Breathitt Gray <william.gray@linaro.org>,
        Lee Jones <lee@kernel.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Peter Robinson <pbrobinson@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH] mfd: rz-mtu3: link time dependencies
Message-ID: <ZLlMAZPzEmSlzlbV@orome>
References: <20230719090430.1925182-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="slp7OkdABcuJ1sYm"
Content-Disposition: inline
In-Reply-To: <20230719090430.1925182-1-arnd@kernel.org>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--slp7OkdABcuJ1sYm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 19, 2023 at 11:02:23AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The new set of drivers for RZ/G2L MTU3a tries to enable compile-testing t=
he
> individual client drivers even when the MFD portion is disabled but gets =
it
> wrong, causing a link failure when the core is in a loadable module but t=
he
> other drivers are built-in:
>=20
> x86_64-linux-ld: drivers/pwm/pwm-rz-mtu3.o: in function `rz_mtu3_pwm_appl=
y':
> pwm-rz-mtu3.c:(.text+0x4bf): undefined reference to `rz_mtu3_8bit_ch_writ=
e'
> x86_64-linux-ld: pwm-rz-mtu3.c:(.text+0x509): undefined reference to `rz_=
mtu3_disable'
>=20
> arm-linux-gnueabi-ld: drivers/counter/rz-mtu3-cnt.o: in function `rz_mtu3=
_cascade_counts_enable_get':
> rz-mtu3-cnt.c:(.text+0xbec): undefined reference to `rz_mtu3_shared_reg_r=
ead'
>=20
> It seems better not to add the extra complexity here but instead just use
> a normal hard dependency, so remove the #else portion in the header along
> with the "|| COMPILE_TEST". This could also be fixed by having slightly m=
ore
> elaborate Kconfig dependencies or using the cursed 'IS_REACHABLE()' helpe=
r,
> but in practice it's already possible to compile-test all these drivers
> by enabling the mtd portion.
>=20
> Fixes: 254d3a727421c ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")
> Fixes: 0be8907359df4 ("counter: Add Renesas RZ/G2L MTU3a counter driver")
> Fixes: 654c293e1687b ("mfd: Add Renesas RZ/G2L MTU3a core driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/counter/Kconfig     |  2 +-
>  drivers/pwm/Kconfig         |  2 +-
>  include/linux/mfd/rz-mtu3.h | 66 -------------------------------------
>  3 files changed, 2 insertions(+), 68 deletions(-)

Assuming that Lee will pick this up:

Acked-by: Thierry Reding <thierry.reding@gmail.com>

--slp7OkdABcuJ1sYm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS5S/8ACgkQ3SOs138+
s6EUEg/6Anop3hMP3iGcBnMEcu0SxusT0pTyZCNLPL1doGbdncByqE1q1zdEca0S
3z9U1vwKHKl+tOfx15dDlS+EBz7wQpkYaU3UUeXVoX7rzGuzDNfe9dmYo63LvoRI
/7ikGCZDb6lfzEhFznRBpNnXQhm4k0+9HDVIH5riXgIc/wepTsENaymyCBxg9ocs
PAZTDaDRt+4mdeP3A7JrCihqU6P8LiSTetGwydHp04s9xVrnlhYHpy7AecnkJH3K
CzkhykUji/qjWHUkcOUp2JGOrEWMFwleadLqvMOZwBm6i5d701K5TospTFvIS4WA
b8u61aSXevOqxcU/IZ2HEqk91uTDFIPNwx/KaupITl3q0SBlxPky9YGnsuy3K4Gg
uEYokiYYqVvAAb83B5IijBq7BQnEYmVR7bc6U7wmQaDtstiHsTgDu1+T44glMVxR
FH0vNUGrw/iekN340d7w6/0DKmtm9UxQsoFzLdSbYOSRU+Go3kSHRG+zJYeryamr
w0CRz+YIV0ZuqXEqys+VS4326WQJM78rXHsbhETcCzH/8xEEweX9BPvmCqsMpP9E
s+jt/jzTPiRgi4a4sHy0X+JF9b7qS0LoIiJ5/NZhPCWThmxcTs7iK3Xa3aIcsfhb
d6kRQ9XjgJ5FqfAVU93Epnl0bzaCKIpSFWSl8eKdT1CenRlI6Lc=
=eYIX
-----END PGP SIGNATURE-----

--slp7OkdABcuJ1sYm--