Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b70fa364-2f68-1336-8d1c-7687f5c4f1b4@amd.com>
Date:   Thu, 20 Jul 2023 20:55:01 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 2/7] EDAC/mce_amd: Remove SMCA Extended Error code
 descriptions
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org,
        nchatrad@amd.com, yazen.ghannam@amd.com,
        Muralidhara M K <muralidhara.mk@amd.com>
References: <20230720125425.3735538-1-muralimk@amd.com>
 <20230720125425.3735538-3-muralimk@amd.com>
 <20230720135950.GHZLk91jGbX7l+7AMz@fat_crate.local>
From:   "M K, Muralidhara" <muralimk@amd.com>
In-Reply-To: <20230720135950.GHZLk91jGbX7l+7AMz@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzBJdU9FUFZMcENJbDNrbGRHbTliVHdWaHJnRDc1L2RzL3dnWlF6OEdxV0N4?=
 =?utf-8?B?VkpIMzRYUThMSUN4RnRmWGtWUERZWXVlMElJcTRCWVdRV0l2OEMzeTY1Nndj?=
 =?utf-8?B?aTIxU1JETzlyaXZMaks1aGhOT2JaeXBmQTBxRWJyNTRudUp0bk1SQmd5M0k0?=
 =?utf-8?B?em5WU3dFWm1reXV3aUozR2JZcjFyNG9ZWERTZUNkcW0yNnMzYU1yVTBab0kw?=
 =?utf-8?B?TTRxcCtLZExaY0lacjhBV0w2TXRoMGxlUm4yNFhLdUpaY0ZnejBGMXZaOWFP?=
 =?utf-8?B?TnNCN1ErU25FbHhDajZkOUp5UFF5NkVnSjBFMjNEeUtEUytJdmhTbmNrVWk2?=
 =?utf-8?B?RWN6RFhHd2NLTFdnVEh0eEZWbTNEVFFqTngwanpVdTljMWJlQ2s5SVJwam8y?=
 =?utf-8?B?YnBLd2ZUZWxiK0hYZGU4VDRZclJiS1gzNHlYdkFzVTR2L0k2K2hwam1od1NJ?=
 =?utf-8?B?WXZzOFlPMk9OdFZPSkgrTDJlRTc1cDN0WFpLTTM5WDcxR3BqaTV5U0hvQWVM?=
 =?utf-8?B?a0VBbmZSbC83SC9XWFV5ZWFOd21XVk56Z0dCNzJYRTlkQmlNSUZEcXlNTGZ1?=
 =?utf-8?B?UG5tdzdFMkRSbmJidkpKYkF2eExoN1VzVHdMcXFSV1lmcnpCdGVYTWFQcjFM?=
 =?utf-8?B?SDRhdEp6TmdadDh1Z0JQRXBQcmI2aWdwMkU3OUdTZzRldlEwSTJpVFlCREZq?=
 =?utf-8?B?aUVLQm1EL05neE9zWnZ3NlBYakk2MkV2ZEo1TDBiVTZhcmZ5T3RvN2sxdkw0?=
 =?utf-8?B?SytCbU50Y3ZWRVUvb0RUUjYzTDJ0SXozalc1eVVIaUNuUHRWOUJJY2NMTWVm?=
 =?utf-8?B?ekxWblhiMTQyOURIeitrdkpJZmJxQzBkSTR2K3M0L0Z3OSttQjVtUHJHUU03?=
 =?utf-8?B?Zk9ScHVjVllKcnhNQ3R3Qmplb0JyTGVLVlhBOE15WXZ6MGZYcWxqNmlVcWpW?=
 =?utf-8?B?RDhtNk1TQVhVVHo5YnVqZjE0d2M4UjRXajlxTnhxT0dzbmRYQkRqR3J0QXFJ?=
 =?utf-8?B?R0N5d0VsUzJxcWt3SFV4eFh4VVl3TjhzTms0aGhkZEFjd1N4T3phaVF6U3kv?=
 =?utf-8?B?NzdCTmxwdkRuVjBPV3pIYjJvOGQyRWFHeXBsRlk4Y085YXVXMzJMdE1WUDRY?=
 =?utf-8?B?dG5NL0o2MjhjTW1TNllvZUtkUitobVY3MXYrazFmUlZ6cmhsREtKbXBCZ3RM?=
 =?utf-8?B?V3BVNk81NzFXaFdFUmxQb1VtQi9OT1Jrb1EvNXd2M09MQ3V3L0NjN3pvZ2dO?=
 =?utf-8?B?dUZpd3lIbFdjdWhvNkYwbThFbG5qbDlPVW42RFpjcE0vR1BhckF2QUkxcGc2?=
 =?utf-8?B?czRRL2dJVytBbmM2U1d0ZmRCeExRSVN6NGtweWFxR0dnSHZhZG1iWUF0UCs5?=
 =?utf-8?B?Si9xMmJLcDQrWXMrNEtvTXhmTVMwS0NldUpsT1lWSTdmb3NiN0wxRCtqR2h3?=
 =?utf-8?B?VkZHS2tSQTl4Q3lIVDlWUytmSFlpSmF3YStjVnpacXVWN3MvTDk3bWNFWEFw?=
 =?utf-8?B?YlBVVW5nMnFPNnV5T3lpeW1WTHArbXpoR0RUZDlhUGJJZkxCLzEzVWVHaUV5?=
 =?utf-8?B?ZHlQL3JZUmlxbno4dmNoTUZsSllVUE56SkJhYVArTlVUeG1YRWxidWdkMis3?=
 =?utf-8?B?KzNNSVo2YmNVRUhwclh4bHdOUzdjSDR4MS9YbjZFbGtTZGdrbTZPaGJoMTFn?=
 =?utf-8?B?WFR6WCs3V1RablREWHRpbGdpL3VuSEM4dG8rYzBGWVV4UnNWV3NTb3hOQk1M?=
 =?utf-8?B?dXg4ZWpxeUVhMXczM3RORzVkeVRLZmxXT09JNDd1Q0RYKzFDTEtxME96cVBR?=
 =?utf-8?B?b0RvTlRFVk95YnBCdGNKMUFZa0FVWVhwYk95L0VrUFk3cGJZZjJnS3NFUXhI?=
 =?utf-8?B?TG1OQkNFNlJDdE4wTUVhWEhDWFB2dFdicEdaNktoZmxPRitpYUZGRE4yblRI?=
 =?utf-8?B?WFFTeVYyVzNVenZqWkdLRG5RdDYvMVRoR0ZtWGdjSnBYOW80amtxbXg5cnNl?=
 =?utf-8?B?VlplWHdObUFVNGU5SzBHQmgvWE5tVDJuRDFkSUQ2RjFjWFQ3NTU2bVNwSXEz?=
 =?utf-8?B?dnRlcDVnNC9CaEdXdVdVaUM1dFArV050UVZrdDE5cDZ4STFQQWlxZzJZSU8v?=
 =?utf-8?Q?CSUdJPYufZTOgq513Zh1Xmyxj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbbd944b-5ff3-4abe-147e-08db893582f2
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB7325.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 15:25:13.0277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0qFbICYyvunYk+WjowE50n+gkCfdRTR01lCH8BweHAjKoOD6ZMZ2Rrd6zZnUN84gyyHZy2PUmnJoct5mSdVUgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5738
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 7/20/2023 7:29 PM, Borislav Petkov wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Thu, Jul 20, 2023 at 12:54:20PM +0000, Muralidhara M K wrote:
>> From: Muralidhara M K <muralidhara.mk@amd.com>
>>
>> On AMD systems with Scalable MCA, each machine check error of a SMCA bank
>> type has an associated bit position in the bank's control (CTL) register.
>>
>> An error's bit position in the CTL register is used during error decoding
>> for offsetting into the corresponding bank's error description structure.
>> As new errors are being added in newer AMD systems for existing SMCA bank
>> types, the underlying SMCA architecture guarantees that the bit positions
>> of existing errors are not altered.
>>
>> However, on some AMD systems some of the existing bit definitions in the
>> CTL register of SMCA bank type are reassigned without defining new HWID
>> and McaType. Consequently, the errors whose bit definitions have been
>> reassigned in the CTL register are being erroneously decoded.
>>
>> Remove SMCA Extended Error Code descriptions. This avoids decoding issues
>> for incorrectly reassigned bits, and avoids the related maintenance burden
>> in the kernel. This decoding can be done in external tools or by referring
>> to AMD documentation. The bank type and Extended Error Code value for an
>> error will continue to be printed as a convenience.
>>
>> Signed-off-by: Muralidhara M K <muralidhara.mk@amd.com>
>> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> ---
>>   drivers/edac/mce_amd.c | 480 -----------------------------------------
>>   1 file changed, 480 deletions(-)
> 
> This needs to stay until rasdaemon has support for decoding errors - and
> I've told you already.
> 
> Lemme tell you again, maybe it'll stick this time.
> 
> In any case, NAK.
> 

Pull request created in rasdaemon for the same.
https://github.com/mchehab/rasdaemon/pull/106/commits/09026653864305b7a91dcb3604b91a9c0c0d74f3

> --
> Regards/Gruss,
>      Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
>