Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c2d10567-cfc6-de6b-cc08-21ab00604d51@acm.org>
Date:   Thu, 20 Jul 2023 08:36:22 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field
Content-Language: en-US
To:     chengming.zhou@linux.dev, axboe@kernel.dk
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhouchengming@bytedance.com
References: <20230720095512.1403123-1-chengming.zhou@linux.dev>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20230720095512.1403123-1-chengming.zhou@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/20/23 02:55, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> This counter is not used anywhere, so delete it.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>   include/linux/blk-mq.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 01e8c31db665..958ed7e89b30 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -393,8 +393,6 @@ struct blk_mq_hw_ctx {
>   	 */
>   	struct blk_mq_tags	*sched_tags;
>   
> -	/** @queued: Number of queued requests. */
> -	unsigned long		queued;
>   	/** @run: Number of dispatched requests. */
>   	unsigned long		run;

Reviewed-by: Bart Van Assche <bvanassche@acm.org>