Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b949697e-319a-7cc1-84d8-1391713fa645@amd.com>
Date:   Thu, 20 Jul 2023 08:31:13 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the
 command waiting loop
Content-Language: en-US
To:     Jason Wang <jasowang@redhat.com>, mst@redhat.com,
        xuanzhuo@linux.alibaba.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, edumazet@google.com,
        maxime.coquelin@redhat.com, kuba@kernel.org, pabeni@redhat.com,
        davem@davemloft.net
References: <20230720083839.481487-1-jasowang@redhat.com>
 <20230720083839.481487-3-jasowang@redhat.com>
From:   Shannon Nelson <shannon.nelson@amd.com>
In-Reply-To: <20230720083839.481487-3-jasowang@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUloTUdBMVdJVExlcVN0bTMxbGdFS0hzc1BJN3FvL1l1bzR3US9ub3BmcWJm?=
 =?utf-8?B?OE1ZUXYrSXA5T3h6SUpZVWU3bTNlbXpRcWpCWmhmZjNLazlmZEtiT3hlR2hi?=
 =?utf-8?B?TUdQc2pyZ1VrTWtRMHdlcGp4Yi81NjgxS3JzSTJFRVZsZjB0R1ZyOWRmSHli?=
 =?utf-8?B?TjRiZWJhVm9kcDVrdmpMSjZvZU9nNGJBZklaWVRxMHpkdGVoQzFZZ3V0SXF2?=
 =?utf-8?B?UWI5VU80TFlCNU0zcWhpdmcwTTVaa3NrSS9NeXVPOG5hTlNZcFJBSmdWQ2o1?=
 =?utf-8?B?ZTM4V3FSdDRBeFA1Tk1xQ1lSc2F2VkpCcTRqRVVaR0tnTksrcWZUZTRvTzZ5?=
 =?utf-8?B?UVppNkpSSDAySWppSWhuNWhNWUNkalBFZDM3ZlpxbzRZZEd1eERlQUROZlE5?=
 =?utf-8?B?NlJqNElKVkt5K3BOaVBzbGpIRGhYbXk4aVZZcmdSMnpJa3I5RWUwZGVyVXhD?=
 =?utf-8?B?UGtlTnV2VDRUaksxVGJ1SC9raUlVQ3dBZHNDelVNSCsybnp3Nk9hNTRtRDUv?=
 =?utf-8?B?RU9hcFgvQVZuamo1aUNLT1dGUWJ4MzhZODkrOE5QeTZDd1pLS2RuUHBMN285?=
 =?utf-8?B?eXBrN3ZydVBuQlBRUXhpcytaT2Y5R0FwdjM1NFlkelBPVU5vRGZaWkl2a0JY?=
 =?utf-8?B?d3VOeDBBS0RKUjBaVXNyekEwS01tRkpqd3pVbko3TUFPRlFqd0VjMDdWZjZM?=
 =?utf-8?B?a1J4ZG5QM2dIeVFXS1hxYWN6NVZWeUJvR2hhNXZvUlE0Ri81TzV0ZWV4anEz?=
 =?utf-8?B?SEk4RkxPT0dGZFpzVEdjMjBSbTNaeHZPRm9JMnZtS0VjSEFENnErOURTZ2Fw?=
 =?utf-8?B?VW5uRnZzU09xN21FcS9KU3BZR3hCenp2SGdYRndzc3FXWU5SVis2U0NiV0Q5?=
 =?utf-8?B?VEM4OHgrNXRZVjh0a2N0SUtIYys4WVpWZDBsMzZFdytSd2NVV1pFK1N1ZlVp?=
 =?utf-8?B?OW5VK3VwRW1MR1o2U3pXcCs3VENsTHFVUTUzV3IxK0k4cnlEdmNZcm5FckJ6?=
 =?utf-8?B?czlpS3JkaEdFZVY1Z1pYSkZaNWJUdjVsaG9ZdTd0K3IzOEpyQXhwWkJKQUcx?=
 =?utf-8?B?QWZkTFpjOHYxUGRaTmVCSkp4L0VOSWVIb0RnN2hIYkFzQThwMHIvZ1I3cnc2?=
 =?utf-8?B?NmJpajdBWVlxVG5ZNWV2eHNFY2o1ekUyRngvN0E0SUxtdzNkVnhhMnFPTDdj?=
 =?utf-8?B?VnVWdklZYmdiS21rdkE1WUZldGF4am9NeXQ1b0c5bXBvOUtGekt4dkZSQWdM?=
 =?utf-8?B?V3dFNnVxUmNiMVcvNk41MDNqUCtwRW9Qb09rVW9GcmtZb2htSFhvdVBxS2ZR?=
 =?utf-8?B?WUFOaEhKblNFMUd0K2llLzFZVmVScUVBTTU5YzdnSTFTZnBFVHJtNzJ2aktn?=
 =?utf-8?B?M1cxVG94SVZjUjVYY1U1a29MdG1jTU44V0pDVEdKWXp4NGROMlJxdXNibVdR?=
 =?utf-8?B?SkNjZTd2NkFZRWEvQi9WYmtuVzlDTSt0enFPaXQzNHFzZUpETkhOUEJYV1Az?=
 =?utf-8?B?VWVNL3NDa0lmdy93S05qVmFrUVZUY1RFd21JMlZ3bDE0d0RCMWUyeEFNNFpQ?=
 =?utf-8?B?djJZbDFSTmpudDZVUkxIWm1RZDBGZktNSUd2TzdTMSs3ZDJjYzdpRFREdFBs?=
 =?utf-8?B?dFdud2RqRkc5cU9SNzRWRU1wMytQckVJUHk5bFFJOURhZHNYZ2JKL3RpMmlV?=
 =?utf-8?B?amZiV21pS3AvajU5M1J1UHVaa090NWE0RnpYQXpVcGRUK3lacHlGdVdUWS83?=
 =?utf-8?B?Mm9rRzM3bEYzOUZqNlpIdUR5SE9tcW95dXBCNW04SE0xbGJUdkF4SHl2azl6?=
 =?utf-8?B?bXlaRVFGcEdqT056cE04L3B6c2dXQVFwNXVEN3ZHazNya3B1Q1NFSzl0Nis2?=
 =?utf-8?B?K1R1RFhsOG5CNk1iaU5zeE1MWnd0ODU1dXVIbFl3Z1hwdWxPaWRRMlJjVVo4?=
 =?utf-8?B?S0dXbC9ma0Z1L2p5NnNXUmdtdTd6bE1TMnhrRGtkZlk3blZZRzR4TUkxMXNT?=
 =?utf-8?B?dW1YcUFtSnBRU1ZtQ210WWtWNUhINjdVQ3VaMzE5Q3oxMEpqNUt6eVl0NHJW?=
 =?utf-8?B?aGpxUUVyVFhJaUxDcVN3bVRqbDlVMWxoeTVTYXcyOUVZM0hjY2YwSzFtSGI2?=
 =?utf-8?Q?xvNm0DTm/zTwDcdS4r40fkhKr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db36a43b-c27e-4b3e-a194-08db89365c05
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 15:31:16.9625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GzaK6e7j3N/xq9aN0+7GumcA+cAEFPeElnjDyUQ/JvUI9kte4NRlec9rhI2XkOPTd7ZbxRiRSBLwuWSNvddgZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9210
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/20/23 1:38 AM, Jason Wang wrote:
> 
> Adding cond_resched() to the command waiting loop for a better
> co-operation with the scheduler. This allows to give CPU a breath to
> run other task(workqueue) instead of busy looping when preemption is
> not allowed on a device whose CVQ might be slow.
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>   drivers/net/virtio_net.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9f3b1d6ac33d..e7533f29b219 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2314,8 +2314,10 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>           * into the hypervisor, so the request should be handled immediately.
>           */
>          while (!virtqueue_get_buf(vi->cvq, &tmp) &&
> -              !virtqueue_is_broken(vi->cvq))
> +              !virtqueue_is_broken(vi->cvq)) {
> +               cond_resched();
>                  cpu_relax();
> +       }

The cover letter suggests that this addresses the infinite poll for 
buggy devices, but I don't see how that is resolved here.  This should 
make it a little nicer to the system, but it still is going to poll 
forever on a device that has gone catatonic.  Is there a reason that I'm 
missing that we don't have a polling limit here?

sln

> 
>          return vi->ctrl->status == VIRTIO_NET_OK;
>   }
> --
> 2.39.3
> 
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization