Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9771555rwp; Thu, 20 Jul 2023 09:25:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlHYHLwUg5WzQ7WhNFovAFhnE+Xj9zYfGNVx6I9mkZTDeRJISBm5ZojGCG0eM3LgZc8Q6p8J X-Received: by 2002:aa7:dcd0:0:b0:521:812a:7f27 with SMTP id w16-20020aa7dcd0000000b00521812a7f27mr5185182edu.25.1689870314194; Thu, 20 Jul 2023 09:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689870314; cv=none; d=google.com; s=arc-20160816; b=PwE2nAoktKkzppHh0DzP+TidxzxSIdNWxBEj5GxOyMkLkWfhUV0Wad3OPL9nLz+BUm ULhcXmSqSb6LEU82K1BMLCganXp0sIohTbIAB901qh/1G7Q0r/zcbDn17mn7QKsqLlrd mnj2SSoBSNyyquuoh3GdOgh2TWMU7M84vhAvq1gpCNxfCKAc9NSJWRrrACld2k541BSw pYdBgSxVOnQymXiKfQGb2mbY/n2lQk43ykmBCqMvHm2s0C7tRH6Kag4NIt672e9EhoT2 92omqpAoMVm3m8dddxHbOcX2N6I39tzDA1k3VJNxfMdbudeXAmHY8rQnFuE5ZsqbAn5n IEkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=fNm6ZQ/64UwMWKutrUq+D5qIa5o1laapzeBHkkGVMEY=; fh=qfO5LNPXeE+qNW4zKcERgQW8DlUaFgo6OgOhlWYyNkk=; b=zf1jjvIoKyI9yfkfCCC6Pl2IgLooicgiInGbkt6DaHY9DX1Zkv28m9EjlvLUc6fEWB a28LYMndgmtwngs4y2RXYy0LyuDNTzfgQ6eV3+NVkGnfzLmG45vuzi4x8mu7GtC8KwxU a7+YF6TRJs8GdzNpgi8ZvqZb7NXQwlX1ttZ90KcPuU6RpAwkf7aIHfzKSDvXpY/hauM9 HyGdgW1vtsDRHvbE61vprNWGstVhkLsyb5/CWc1lU8Eqr7hZMnJSBvKFp8/+O6jQ3D3E QJolwPWjFXq0G7Lqg3Gfek2N3Si6GCEhJ4qNXYmv4FB4QaPQ4gUZrUHl71K71yh774GN ogqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a056402055200b00521985f581bsi975788edx.27.2023.07.20.09.24.45; Thu, 20 Jul 2023 09:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjGTQEd (ORCPT + 99 others); Thu, 20 Jul 2023 12:04:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbjGTQEb (ORCPT ); Thu, 20 Jul 2023 12:04:31 -0400 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1956FCE; Thu, 20 Jul 2023 09:04:31 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qMW70-0004pa-2K; Thu, 20 Jul 2023 16:02:42 +0000 Date: Thu, 20 Jul 2023 17:02:32 +0100 From: Daniel Golle To: Christoph Hellwig Cc: Jens Axboe , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Dave Chinner , Matthew Wilcox , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Jan Kara , Damien Le Moal , Ming Lei , Min Li , Christian Loehle , Adrian Hunter , Hannes Reinecke , Jack Wang , Florian Fainelli , Yeqi Fu , Avri Altman , Hans de Goede , Ye Bin , Greg Kroah-Hartman , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [RFC PATCH 6/6] block: implement NVMEM provider Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 12:04:43AM -0700, Christoph Hellwig wrote: > The layering here is exactly the wrong way around. This block device > as nvmem provide has not business sitting in the block layer and being > keyed ff the gendisk registration. Instead you should create a new > nvmem backed that opens the block device as needed if it fits your > OF description without any changes to the core block layer. > Ok. I will use a class_interface instead.