Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 16:58:49 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Julien Panis <jpanis@baylibre.com>
Subject: Re: [PATCH v5 12/12] can: m_can: Implement transmit submission
 coalescing
Message-ID: <ZLlZudoYyarYmEjz@corigine.com>
References: <20230718075708.958094-1-msp@baylibre.com>
 <20230718075708.958094-13-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718075708.958094-13-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BEV+Z5JX7jXzccnJREoWLqJmQolXhki5j5YCajdINblQK6I4oIYVup7Rs2pN?=
 =?us-ascii?Q?1jXcqFBeCVQCxlv43t5qr6MvI9sfgrFdTvGnAX405d6o3UWd0bAidujIZe03?=
 =?us-ascii?Q?TGczu1NLHyiu/zyLCjUHobEQpIl+90A9SdRy+tI8UBgomy29yEXswDlSIE0O?=
 =?us-ascii?Q?bqaRgxFc0AA6H+RzEFHG4sJMmt1UpQatnwzSEp4fElr0wAS5qsq1bnFhRCs5?=
 =?us-ascii?Q?wc2DXEwYHm3mp4JVBMlqSYUPN4N2b///h5uQZLIVJ0AI93LQc3j/h3TxzRcn?=
 =?us-ascii?Q?8GkM+zMEazAFG2xtv8RauhBs65st9YHN9GprHqT6uOPacunfGQ+HNiSkzGUP?=
 =?us-ascii?Q?YHSPyWKspcz0jMMy6xZWRGyDptwTetnY8AZk73DxkaX9uGz+hiM5kfQNs0Mu?=
 =?us-ascii?Q?O65RnShyCJN4MN0n0c0wmTVw6y6NqkvxVfsrrbiPitY39IkRZPIv/OjhAPIj?=
 =?us-ascii?Q?dicFjcarfye6vY/0yIZVGD/AO/bI/ydI/sVOZ07/pG1qBSeBnTB4w20LtGXZ?=
 =?us-ascii?Q?R8bbjWKEFUzVE11IFcaJbSshrmeb2cQVSjPJHNDbQqe6MAIGirDOefdF2shj?=
 =?us-ascii?Q?bJChvVAZeF+3usT49OePB30thCDq97O5i0XZKIHuHOiqvfxlR2bhYqbUhZiQ?=
 =?us-ascii?Q?LJKAmt9BirSgJ5w5ZG+hHRpIOqQI+WwUV/4fdy5ppivocHHvNJPLhSLxoOyl?=
 =?us-ascii?Q?l/mHJQlg1jPJLGPIadT1hnpxVeuWbx27OGYtpQuQLDrV0lqHwOAHSS0OmSfN?=
 =?us-ascii?Q?aU6EJqOPNCYGCIz+gUA7xtQWDojCYl0ZYy5lyHlwwi3rUNZ733EOnje80/D/?=
 =?us-ascii?Q?kel3A9yd/9d5cza+V0RAVz9fMTynk+rLvF11fCwsE0ZHICKEWlzW7ArXzdJ9?=
 =?us-ascii?Q?j8sqg0tcrkoNfiQVpJJvqytvaO/HGcj1BMX83qnYkg5k+HVsz6BgBYiXjosf?=
 =?us-ascii?Q?1v9xxZ1N9svd14cRL5GAZRyBiR0lOpF2BFIiaa6tvSteyQB4DeaU2d0eY9b1?=
 =?us-ascii?Q?qIzVm9yIUc/+Ior4P4KaV04zdiByGZXAmZAfjMoubJ/6UpEA2rC62TumYKGw?=
 =?us-ascii?Q?FVxwnKDHIaXa7etsDeo0QDQPxiLOv6tLg7xDlrPPmYjTbkMSjOP0Ryjz1Qpy?=
 =?us-ascii?Q?Za4M+SELnJpoGSOdVGcFn0qmFtBzC97bH9mHZ9HZn0+UsWhcIuOc4ienuepq?=
 =?us-ascii?Q?tps1TTqH6pz1z/xnBLd2fHGEi6HXF8CfjfKxT2WDgoPLd1ofbJwwBivwJjlf?=
 =?us-ascii?Q?8f5bxhNLXb/Mq2vcMcHPmFYNGB63Ol/un8Q6cJJI2Y0kW7RCsRBRLGZP8UAc?=
 =?us-ascii?Q?2de3/MAqWxt0Vj/8XACV8TfID//GE22Th+VKIs5/6Hp4wzZSNl4bz2q4/wB1?=
 =?us-ascii?Q?sG919EurepUrXMpUjjnAu6EKrkfLL8XenB96mYTVfVyYJlfOkRr2mhia3SE5?=
 =?us-ascii?Q?KbMu0FzSg3CX4X5cmC1aBSVCtLkBue3fbhCp920wYBM0UZf0hEoBDqg4cNcJ?=
 =?us-ascii?Q?3VbbnuNTsr97Cf0kqWaL0VlGFnTLi76keHfkxJ3rMG/53GiiOraD3E5p19Qv?=
 =?us-ascii?Q?sAJBn2M3rnk1GwcFDvatctkf9t5hnlCVQZqK43XdB9XeH/alhg4eaxNlajmD?=
 =?us-ascii?Q?eg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99ae774b-d8f9-48e1-5f13-08db893a394b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 15:58:56.6795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iCTaoZqZ1E2QDw8ySJD4xS2tMpJ50oCXFj8zuVz2ICUOvit780jl0hLNQ2CEbEm3huvjx4vPzSKn5X07ltBplvWlQFA9cSi/vxpFkNNWoDA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR13MB6184
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 18, 2023 at 09:57:08AM +0200, Markus Schneider-Pargmann wrote:
> m_can supports submitting multiple transmits with one register write.
> This is an interesting option to reduce the number of SPI transfers for
> peripheral chips.
> 
> The m_can_tx_op is extended with a bool that signals if it is the last
> transmission and the submit should be executed immediately.
> 
> The worker then writes the skb to the FIFO and submits it only if the
> submit bool is set. If it isn't set, the worker will write the next skb
> which is waiting in the workqueue to the FIFO, etc.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>