Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 16:46:06 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Martin Kurbanov <mmkurbanov@sberdevices.ru>
Cc:     Jerome Brunet <jbrunet@baylibre.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v2 2/2] spi: amlogic-spifc-a1: add support for
 max_speed_hz
Message-ID: <c118f69d-db32-4544-83d5-14de089d5b51@sirena.org.uk>
References: <20230706110331.19794-1-mmkurbanov@sberdevices.ru>
 <20230706110331.19794-3-mmkurbanov@sberdevices.ru>
 <1jlefm6h8g.fsf@starbuckisacylon.baylibre.com>
 <5dc58681-d89f-8a8d-4da5-ccfa142fa15a@sberdevices.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rIgO7hjWxljNfj4v"
Content-Disposition: inline
In-Reply-To: <5dc58681-d89f-8a8d-4da5-ccfa142fa15a@sberdevices.ru>
Precedence: bulk


--rIgO7hjWxljNfj4v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 20, 2023 at 06:41:11PM +0300, Martin Kurbanov wrote:
> On 11.07.2023 10:25, Jerome Brunet wrote:

> >> +	ret = clk_set_rate(spifc->clk, freq);
> >> +	if (ret)
> >> +		return ret;

> >> +	spifc->curr_speed_hz = freq;

> > There is no guarantee that clk_set_rate() has set the rate you have
> > requested, at least not precisely. You should call clk_get_rate() here.

> Are you referring to a situation where there is a change in the rate due
> to a request from another client, such as a sibling driver with the same
> parent clock?

The clock may simply not be able to generate exactly the rate you
requested, the rate will be rounded to some value that the clock can
actually generate.

--rIgO7hjWxljNfj4v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS5Vr4ACgkQJNaLcl1U
h9BanAf/TAsXNc+hfSP68yz4+OEr+7uK3DVU9ymeAUuAi/ksybVR0vSqYlZeDm0c
7Ilfl/jVxnXfF/NBA8tQdNu8qIX67fVhIWVxBLWA2p1/idx+cAa98gTeTr33Fg/5
dP/J/oqqWCmc7+lIOlyCQfyQelGqalUXRcWwkwj5aYo2gd1rez49E1/SCybQKqYR
UTJrHjRtKvkAoTPJ2/u4CK872i4PyDfcYqmClW6i/v3D9CF39nOo6/QJYx2fZuMn
napO9rczG5ViMNbt+37LYT1rsDAi9hk31doyxeFSp+MsvsFtDb5W5myMJbbbrEXc
6227n7xCLQ5H+LSYD56sTHyAr/H4IA==
=MtQJ
-----END PGP SIGNATURE-----

--rIgO7hjWxljNfj4v--