Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b86b4a28-29d0-ed2e-ab82-449d1652b10c@gmail.com>
Date:   Thu, 20 Jul 2023 23:03:48 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add testcase for xdp
 attaching failure tracepoint
Content-Language: en-US
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Yizhou Tang <tangyeechou@gmail.com>, kernel-patches-bot@fb.com,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>
References: <20230719125232.92607-1-hffilwlqm@gmail.com>
 <20230719125232.92607-3-hffilwlqm@gmail.com>
 <CAADnVQKxGNNbn-OnQzrbcOfC6c_5tL0PSfZM0y8h_FJ0Pg=sDg@mail.gmail.com>
From:   Leon Hwang <hffilwlqm@gmail.com>
In-Reply-To: <CAADnVQKxGNNbn-OnQzrbcOfC6c_5tL0PSfZM0y8h_FJ0Pg=sDg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/7/20 01:39, Alexei Starovoitov wrote:
> On Wed, Jul 19, 2023 at 5:53 AM Leon Hwang <hffilwlqm@gmail.com> wrote:
>> +       return 0;
>> +}
>> +
>> +/*
>> + * Reuse the XDP program in xdp_dummy.c.
>> + */
>> +
>> +char LICENSE[] SEC("license") = "GPL";
> 
> Do you have a hidden char in the above?
> git considers the last line to be part of the commit log instead
> of part of the patchset and it fails CI.

Sorry for it.

I'll use ./scripts/checkpatch.pl to check it again to make sure no style
issue, then resend this patchset.

Thanks,
Leon