Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 18:39:32 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mohan Kumar <mkumard@nvidia.com>
Cc:     treding@nvidia.com, jonathanh@nvidia.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, spujar@nvidia.com
Subject: Re: [PATCH] arm64: tegra: Add audio support for IGX Orin
Message-ID: <ZLljRBBHl_3jsKGg@orome>
References: <20230620155847.14598-1-mkumard@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vLEOq6j5hPYuBGgG"
Content-Disposition: inline
In-Reply-To: <20230620155847.14598-1-mkumard@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--vLEOq6j5hPYuBGgG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 20, 2023 at 09:28:47PM +0530, Mohan Kumar wrote:
> Add audio support for the NVIDIA IGX Orin development kit having P3701
> module with P3740 carrier board.
>=20
> Move the common device-tree nodes to a new file tegra234-p3701.dtsi and
> use this for Jetson AGX Orin and NVIDIA IGX Orin platforms
>=20
> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
> ---
>  .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  |    1 +
>  .../boot/dts/nvidia/tegra234-p3701-0008.dtsi  |    1 +
>  .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 1991 ++++++++++++++++
>  .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 2009 -----------------
>  .../boot/dts/nvidia/tegra234-p3737-0000.dtsi  |   41 +
>  .../nvidia/tegra234-p3740-0002+p3701-0008.dts |   91 +-
>  .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  |   56 +
>  7 files changed, 2176 insertions(+), 2014 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi
[...]
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dt=
s b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> index 43d797e5544f..2b7856b303b4 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
[...]
> @@ -103,7 +99,7 @@
>  		};
> =20
>  		hda@3510000 {
> -			nvidia,model =3D "NVIDIA IGX HDA";
> +			nvidia,model =3D "NVIDIA Jetson IGX Orin HDA";
[...]
> @@ -151,4 +147,89 @@
[...]
> +		label =3D "NVIDIA Jetson IGX Orin APE";
[...]

The platform is called "NVIDIA IGX Orin Development Kit", so shouldn't
these be "NVIDIA IGX Orin HDA" and "NVIDIA IGX Orin APE", respectively?

Thierry

--vLEOq6j5hPYuBGgG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS5Y0QACgkQ3SOs138+
s6Fb6Q//XqMgA3W+sUybflSZbh5Kq41ThyM1yVl9KE0/v8+0uPwRwT7zGwXft/pB
O6BFHvPaSCMQHQ2FKcTOVAnIp1bIRGWb8taI7W4zDI57KqWiJYrBk68sdj8HvrsY
GZ/z5o1ethG5vkf+S4HxlLCjEsFqsStbzg21sMThMQb/Vwwr0YMBy9/3o+uVvSSe
SEQJoki2ExzpTCX9VNPQL6xz9O289pgFXYpAbZ3AFtmVn1Yqpvlj9BvtnsZKQB46
Q+dVQg965UOXYROYFirbh/ecj4zn4Eqi24pSZMv9QU4Peuiu7QDXUbBgTjXkzt5J
2e2uHMNGhU6KC4/hgpNizSqN4ITN6WGwmgl77Bq9lD/K+Y0WRCiROvvt24Eh4dhY
NTvtJXoorFlBD3fD+sJbUZyEXrJ0FYeFpC6vZX7XNW38sKizEn8XBOxYpqTuehva
JZK++p6GEFNnMzJyGgmP/wnk3e/MsfQnrAENqZRkQshXqLgVSpJMl3MOwFDvn26f
k8su8sr9hEF6SSQyuSsKddN9HLC8sSjfPpUZNHUbikQBGyQl2SSWoTCd12S0eX8/
Bwmiek7riu4yx1xwHWzpXdXy4lAFrTuY+UHJvRJVvvufach+xyiwn+h9t7deEnMS
Sv9vIdvTIA3GgK7jjSRdOh2ypc0NcsOJ3/5ivBWR27nGW0R9JJ0=
=YtvD
-----END PGP SIGNATURE-----

--vLEOq6j5hPYuBGgG--