Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 18:40:02 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mohan Kumar <mkumard@nvidia.com>
Cc:     treding@nvidia.com, jonathanh@nvidia.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, spujar@nvidia.com
Subject: Re: [PATCH] arm64: tegra: Add audio support for IGX Orin
Message-ID: <ZLljYqE_gDzh_WgT@orome>
References: <20230620155847.14598-1-mkumard@nvidia.com>
 <ZLljRBBHl_3jsKGg@orome>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="23DfovU3nZbHCktE"
Content-Disposition: inline
In-Reply-To: <ZLljRBBHl_3jsKGg@orome>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--23DfovU3nZbHCktE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 20, 2023 at 06:39:32PM +0200, Thierry Reding wrote:
> On Tue, Jun 20, 2023 at 09:28:47PM +0530, Mohan Kumar wrote:
> > Add audio support for the NVIDIA IGX Orin development kit having P3701
> > module with P3740 carrier board.
> >=20
> > Move the common device-tree nodes to a new file tegra234-p3701.dtsi and
> > use this for Jetson AGX Orin and NVIDIA IGX Orin platforms
> >=20
> > Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
> > ---
> >  .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  |    1 +
> >  .../boot/dts/nvidia/tegra234-p3701-0008.dtsi  |    1 +
> >  .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 1991 ++++++++++++++++
> >  .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 2009 -----------------
> >  .../boot/dts/nvidia/tegra234-p3737-0000.dtsi  |   41 +
> >  .../nvidia/tegra234-p3740-0002+p3701-0008.dts |   91 +-
> >  .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  |   56 +
> >  7 files changed, 2176 insertions(+), 2014 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi
> [...]
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.=
dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > index 43d797e5544f..2b7856b303b4 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> [...]
> > @@ -103,7 +99,7 @@
> >  		};
> > =20
> >  		hda@3510000 {
> > -			nvidia,model =3D "NVIDIA IGX HDA";
> > +			nvidia,model =3D "NVIDIA Jetson IGX Orin HDA";
> [...]
> > @@ -151,4 +147,89 @@
> [...]
> > +		label =3D "NVIDIA Jetson IGX Orin APE";
> [...]
>=20
> The platform is called "NVIDIA IGX Orin Development Kit", so shouldn't
> these be "NVIDIA IGX Orin HDA" and "NVIDIA IGX Orin APE", respectively?

Oh, and no need to resend, I can fix this up when I apply.

Thierry

--23DfovU3nZbHCktE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS5Y2IACgkQ3SOs138+
s6ESVhAAsTZP40c5ASBe4C7mUMahAduFRPg/8KOdje4Zxwq/DvhgDcsR7Sv/IRYB
lS5IIuF6idOgCxKzrthBAUaKexkNhFZzLO7Try0PiaCHkq6MrqoYpdDFL00O0sFJ
HwYguX0kFQ/+IbI/tTbjcU9LY6R7tYb3Q39vLy5D7XEB/fpbBwlP5U9w8yhJqe/t
9/e1QYe1CVAP+SQVmmiOkt+vM80KRiGXjXVBdjh1UOR/Ted46r2jfWSA6BFRpyyj
vdztzCEY8bxGZDTHrmWkrAUmcWQpVJdMoKtscI6r8tlFol9ZWZ7gZ7w2wXBnUxHG
LWA7xr8LrRZVoemNqCKBIr6RbLQ01PMzxv/5/EeXLuEiX/+LYxw0/E27SKhtdMz7
TI6FZgEDheiozzWHNakYkEOM+0evcfze08mGCZ8euJdUxrh/wAnMS/JVsVJZlfKt
h5rV8wnhkwX5Sz8tY8Uf2Ij8/UMnCfwD2rcJycYXgls0STw7hfAVy4S1IxH85RqP
J6A2sPrfbfUhcQQDgTOlG9zDfHfuBkx4w542kigrVH49TxtqOCcri22k7+uoGqQT
vzr6dKZPN4IBNIkYkrT1NrFeXENYZAunVtlnOu2P/o41fjT1jvNhGLZEDUBNt/YT
VyIU41CqVAetdm5hSPrUuHTWKDzK1+j31MKVdDLdS/bCX95YrN0=
=UCk9
-----END PGP SIGNATURE-----

--23DfovU3nZbHCktE--