Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9befc235e14b8a8ca539c95eadcc4bff2d758d1.camel@linux.intel.com>
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Support more than 8
 sockets.
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Frank Ramsay <frank.ramsay@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 20 Jul 2023 09:46:16 -0700
In-Reply-To: <20230720160803.1648970-1-frank.ramsay@hpe.com>
References: <20230720160803.1648970-1-frank.ramsay@hpe.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2023-07-20 at 11:08 -0500, Frank Ramsay wrote:
> MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8
> sockets or fewer.
> On a system with more than 8 sockets intel-speed-select silently
> ignores everything
> beyond the 8th socket, rendering the tool useless for those systems.
> 
> Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.
> 
Thanks for the patch. I will queue this for the next release.

-Srinivas

> Signed-off-by: Frank Ramsay <frank.ramsay@hpe.com>
> ---
>  tools/power/x86/intel-speed-select/isst.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst.h
> b/tools/power/x86/intel-speed-select/isst.h
> index 54fc21575d56..8def22dec4a2 100644
> --- a/tools/power/x86/intel-speed-select/isst.h
> +++ b/tools/power/x86/intel-speed-select/isst.h
> @@ -79,7 +79,7 @@
>  
>  #define DISP_FREQ_MULTIPLIER 100
>  
> -#define MAX_PACKAGE_COUNT      8
> +#define MAX_PACKAGE_COUNT      32
>  #define MAX_DIE_PER_PACKAGE    2
>  #define MAX_PUNIT_PER_DIE      8
>