Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230720132535.23413-1-aboutphysycs@gmail.com>
In-Reply-To: <20230720132535.23413-1-aboutphysycs@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 20 Jul 2023 19:06:44 +0300
Message-ID: <CAHp75VeDGa9eKJv+4F13LRLhCutTWOhQcU66CnDaeTLCsSbP8A@mail.gmail.com>
Subject: Re: [PATCH] gpio : max77620: remove unneeded platform_set_drvdata() call
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        andy@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org,
        Alexandru Ardelean <alex@shruggie.ro>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 20, 2023 at 4:26=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail.=
com> wrote:
>
> This function call is not required because no counterpart
> platform_get_drvdata() call is present to leverage the private data of
> the driver.
> Since the private data is confined to this driver file, external access
> is not feasible.
> The use of this function appears redundant in the current context of the
> driver's implementation.

Use full room of the lines, no need to start each sentence at a new line.

Also, fix the Subject.
It should be prefixed with "gpio: DRIVER: ", where DRIVER is one in
question. This applies to all your last patches.

--=20
With Best Regards,
Andy Shevchenko