Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48c1d70b-d4bd-04c0-ab46-d04eaeaf4af0@intel.com>
Date:   Thu, 20 Jul 2023 18:46:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH RFC net-next v2 7/7] net: skbuff: always try to recycle PP
 pages directly when in softirq
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230714170853.866018-1-aleksander.lobakin@intel.com>
 <20230714170853.866018-10-aleksander.lobakin@intel.com>
 <20230718174042.67c02449@kernel.org>
 <d7cd1903-de0e-0fe3-eb15-0146b589c7b0@intel.com>
 <20230719135150.4da2f0ff@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230719135150.4da2f0ff@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3V4ZmlnYTB6SSs5Q1pXOFR1em01ckZtdXBONTVmNnNEblNJdnJHRTJKNndn?=
 =?utf-8?B?eE13bWNTekFuc3B1aFEzMjNSa1p6Z2NDUG1rMmwwUEdoc1huUURtVWZnSzVh?=
 =?utf-8?B?UXZrYmU4b1lLK1ErWWhZOVRIZ3lyakFtWHNybGtCNmM1S2pxQkZxR2pPcEox?=
 =?utf-8?B?Y01KM2NSdHNoQmJwMC9oYXUwZmhXSnZlZ3JFSjhaSm8yRGlMNUF5eEVBT1NR?=
 =?utf-8?B?aFlZMmE5TVQ2cE94cDVldW9Mczhhci9obnE2UXVSVmNTZGQvRjhFRDIrODBW?=
 =?utf-8?B?WEJTckNCUlcrN3VqckJ3MEpHaWpuZkM5Qis5ejZhZ1JXVTd3RzRXeng2OGRW?=
 =?utf-8?B?Tmk0UUFPdHFCdzNwemFTRDQ3b1M3cnBPQWZXbi9iNXY1UFV0SHBiekpjOEtO?=
 =?utf-8?B?OXZzZE5Ldm90eTR4WHVTZ1lCdDlkcTNvZkEzTDFWVWZvK0pjTEx5QWhtTXgv?=
 =?utf-8?B?SGJqWXQvYUlncjQxemplUklPVkJlbGRpVlZBTHA5TU9lb0M3R3I4VGNmSTJq?=
 =?utf-8?B?QWIvNmlwU0pWOGs3eWhLeTdIT01qVkxUa1NFQmdIcXk2aUhlZkgrV2xXc0Rn?=
 =?utf-8?B?eWNzcHdWdTBNSGJuMUtzU3RUbVdzekRQT3FXUERrMkhIeWtrY09uQW9kMitH?=
 =?utf-8?B?b2FzdjM2MVZvTTczSjBXWERBYzExdFVmdXY0cERxMWJ2ZDNIY25DdUJ3Q2M2?=
 =?utf-8?B?eXRXV1FsNWpBUjdsMDFKOWFzWFRWY1RVNUwwVGloSmVIUktzTWczK1dETkpu?=
 =?utf-8?B?QnhFMUkxYkduWS9aVVNwdUMwR25jWDI2U0JGM0pHT0kvNEJmcGsrUVVka3dn?=
 =?utf-8?B?S2p5UU5CTFJPS213S09zWmVaQ01vaVNoZzVzeVdCbHdyblB3MmR5L0IwWUY3?=
 =?utf-8?B?ZGlSN3dkTjRoeUYxZWZFZEdZQzhRd1hTTEExTnkrbHB6VWRwd0dKYWNOT3Nj?=
 =?utf-8?B?SlZROWVqT2k5R3FwQWc2WHBVNnB5aU1KR3haTk9oNUttMS82bUNpYWUxL2lq?=
 =?utf-8?B?WmtPRDlVQWphWE9nSWpnZWoxNmpEL2pISmtmTWVCcHFIdFduamgvV2FaUXM5?=
 =?utf-8?B?dVJPbk9jM2VVcGJEWTJBb0VzY3l3M05leWJsNDdQZ3pnT05wVDd6VEpBZ1FF?=
 =?utf-8?B?cGZmeFdkcFU2Y0VTTm9RRE1UZjd2ZmpSK3E5MXM4Q211OHFvSlJlcnRESWly?=
 =?utf-8?B?WUlyczJkbHRqbDZlLzg0VUJSVFVBaFdQYUZSRkdCY2J0T2FFemlsS1FiQlkx?=
 =?utf-8?B?K0lwNjVqazdMaGFlSnhqZzdrYU4xNXhYNWdBRUR3cHdIM1NoS3h5dnlkeW54?=
 =?utf-8?B?TFhDM1lIeDdWUERFYThZTjdYZmh1K3c1eDNuRjd4R1N2SjVDcDM4MDF2cXNy?=
 =?utf-8?B?RU1wRktMY2RPSFJsU2pSQ29YV05UV1p2MXdxbGlwRnM5dHdFSVUxWGwxV2h1?=
 =?utf-8?B?TTZ0UlhTdXdMSDVYY3hOSUFpeVlkeFBVU1Bhb3R4WW5tSWFGTVRaalBTbnJt?=
 =?utf-8?B?RGU1R1Rhd3Q4UHR0b1dNdWRaNW90bDAySW1vblFiUU9VNlQ5eFVGVTFNVXNQ?=
 =?utf-8?B?YlFaK2NTZVU4QXFrTkNvMnJKUW9xSEt0ODFWamlkTmlNU05pblFpZmQ5Tjlp?=
 =?utf-8?B?Wlc4YVU3MkUzVmwyUEhiZGlTa0RzZUFPWWJkaXBzdk9hdWNvRmNKQnhFWWJY?=
 =?utf-8?B?K3lhSmVWTFk2bHNFMyt0NjVPQlYyZFAwVTZvUkhEUlhaWko5eWZZTTZLRDNp?=
 =?utf-8?B?ejBGQ3I0QWFSZUc1VGtZM09rVU50cVp1bWN3VzFWWVozQXVRU1Q2cGd4eWlB?=
 =?utf-8?B?M0xHWjQvOFk4QWlmYk4wUnB4RHNIYjZldlBjT08zbFlLcUR1QnUxQjZWaFhP?=
 =?utf-8?B?ZDJJWittajhtaUgzcXlUMXQzNkRxU2svaTRWNlBJL1dSbDJrdUlKWHJkSk1F?=
 =?utf-8?B?elhvbWEzRzdrQVEvU2Vwd2F4c0NOVnZ0WjZzNWN2UzZOMTBuR3o2UTJiYXkz?=
 =?utf-8?B?anQzQi8wVU1xbS91ZDBSYWw3SDlWQnpHdk04Q0tJVEpzVVJ4ZWdSR3hYLzVT?=
 =?utf-8?B?N3QxNmtSUmEyOFNsbUhPa1Z6RXNDL2JKZTliVG13TThDSHVLa2pZaEYzNHIz?=
 =?utf-8?B?aVdCN20yMllJekNJa0JQUDIrNXhVMHJhL2RIUkFVZDM5V0ZQZFY2ZVNUQ1JV?=
 =?utf-8?B?blE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d35493c4-4651-49d7-0bdb-08db89411427
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 16:48:01.0780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OAAQsrtj92JXO0N41ncvwoMdpCkWkXZrhMfJvwx9hw8BYBcgs3mufCDUi9s+870MBoCYmctYgP++Io9PpX7sRQaMhD1+E8VDaM9CjIoUhOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6158
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 19 Jul 2023 13:51:50 -0700

> On Wed, 19 Jul 2023 18:34:46 +0200 Alexander Lobakin wrote:
>>> What if we got here from netpoll? napi budget was 0, so napi_safe is
>>> false, but in_softirq() can be true or false.  
>>
>> If we're on the same CPU where the NAPI would run and in the same
>> context, i.e. softirq, in which the NAPI would run, what is the problem?
>> If there really is a good one, I can handle it here.
> 
> #define SOFTIRQ_BITS		8
> #define SOFTIRQ_MASK		(__IRQ_MASK(SOFTIRQ_BITS) << SOFTIRQ_SHIFT)
> # define softirq_count()	(preempt_count() & SOFTIRQ_MASK)
> #define in_softirq()		(softirq_count())

I do remember those, don't worry :)

> 
> I don't know what else to add beyond that and the earlier explanation.

My question was "how can two things race on one CPU in one context if it
implies they won't ever happen simultaneously", but maybe my zero
knowledge of netcons hides something from me.

> 
> AFAIK pages as allocated by page pool do not benefit from the usual
> KASAN / KMSAN checkers, so if we were to double-recycle a page once
> a day because of a netcons race - it's going to be a month long debug
> for those of us using Linux in production.

if (!test_bit(&napi->state, NPSVC))

? It would mean we're not netpolling.
Otherwise, if this still is not enough, I'do go back to my v1 approach
with having a NAPI flag, which would tell for sure we're good to go. I
got confused by your "wouldn't just checking for softirq be enough"! T.T
Joking :D

Thanks,
Olek