Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 10:10:07 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Bradescu, Roxana" <roxabee@google.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] kvm/vfio: avoid bouncing the mutex when adding
 and deleting groups
Message-ID: <ZLlqb8Hk0S3AkEsf@google.com>
References: <20230714224538.404793-1-dmitry.torokhov@gmail.com>
 <20230714224538.404793-2-dmitry.torokhov@gmail.com>
 <BN9PR11MB5276BCE644231C440053AA118C39A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZLd+X7Zcnlq52Tp+@google.com>
 <BN9PR11MB52763F0990CD23DB63AC36578C3EA@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB52763F0990CD23DB63AC36578C3EA@BN9PR11MB5276.namprd11.prod.outlook.com>
Precedence: bulk

On Thu, Jul 20, 2023 at 02:36:16AM +0000, Tian, Kevin wrote:
> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Sent: Wednesday, July 19, 2023 2:11 PM
> > 
> > On Wed, Jul 19, 2023 at 05:32:27AM +0000, Tian, Kevin wrote:
> > > > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > Sent: Saturday, July 15, 2023 6:46 AM
> > > >
> > > > @@ -165,30 +161,26 @@ static int kvm_vfio_group_add(struct
> > kvm_device
> > > > *dev, unsigned int fd)
> > > >  	list_for_each_entry(kvg, &kv->group_list, node) {
> > > >  		if (kvg->file == filp) {
> > > >  			ret = -EEXIST;
> > > > -			goto err_unlock;
> > > > +			goto out_unlock;
> > > >  		}
> > > >  	}
> > > >
> > > >  	kvg = kzalloc(sizeof(*kvg), GFP_KERNEL_ACCOUNT);
> > > >  	if (!kvg) {
> > > >  		ret = -ENOMEM;
> > > > -		goto err_unlock;
> > > > +		goto out_unlock;
> > > >  	}
> > > >
> > > > -	kvg->file = filp;
> > > > +	kvg->file = get_file(filp);
> > >
> > > Why is another reference required here?
> > 
> > Because the function now has a single exit point and the original
> > reference is dropped unconditionally on exit. It looks cleaner than
> > checking for non-zero "ret" and deciding whether the reference should be
> > dropped or kept.
> > 
> 
> A comment is appreciated. otherwise,
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Thank you for the review! However I do not think any comment is needed,
if one is looking at the final source and not the patch form, the reason
for taking another reference is plain to see.

Thanks!

-- 
Dmitry