Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230718101726.1864761-1-cristian.marussi@arm.com> <20230718132028.wtycky4amu35xxcy@bogus>
In-Reply-To: <20230718132028.wtycky4amu35xxcy@bogus>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 20 Jul 2023 20:28:39 +0200
Message-ID: <CAJZ5v0hTBVVqv-vJrg6CUZLt-VXkmmHHctJ83tACnQ0zs-Lt4Q@mail.gmail.com>
Subject: Re: [PATCH v2] powercap: arm_scmi: Remove recursion while parsing zones
To:     Sudeep Holla <sudeep.holla@arm.com>,
        Cristian Marussi <cristian.marussi@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pm@vger.kernel.org, james.quinlan@broadcom.com,
        f.fainelli@gmail.com, vincent.guittot@linaro.org,
        lukasz.luba@arm.com, "Rafael J . Wysocki" <rafael@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Jul 18, 2023 at 3:20 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Tue, Jul 18, 2023 at 11:17:26AM +0100, Cristian Marussi wrote:
> > Powercap zones can be defined as arranged in a hierarchy of trees and when
> > registering a zone with powercap_register_zone(), the kernel powercap
> > subsystem expects this to happen starting from the root zones down to the
> > leaves; on the other side, de-registration by powercap_deregister_zone()
> > must begin from the leaf zones.
> >
> > Available SCMI powercap zones are retrieved dynamically from the platform
> > at probe time and, while any defined hierarchy between the zones is
> > described properly in the zones descriptor, the platform returns the
> > availables zones with no particular well-defined order: as a consequence,
> > the trees possibly composing the hierarchy of zones have to be somehow
> > walked properly to register the retrieved zones from the root.
> >
> > Currently the ARM SCMI Powercap driver walks the zones using a recursive
> > algorithm; this approach, even though correct and tested can lead to kernel
> > stack overflow when processing a returned hierarchy of zones composed by
> > particularly high trees.
> >
> > Avoid possible kernel stack overflow by substituting the recursive approach
> > with an iterative one supported by a dynamically allocated stack-like data
> > structure.
> >
> > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > Fixes: b55eef5226b7 ("powercap: arm_scmi: Add SCMI Powercap based driver")
>
> Makes sense,
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Applied as 6.6 material, thanks!