Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Paolo Abeni <pabeni@redhat.com>
cc:     =?us-ascii?Q?=3D=3FUTF-8=3FQ=3F=3DE7=3D8E=3D8B=3DE6=3D98=3D8E-=3DE8=3D?=
         =?us-ascii?Q?BD=3DAF=3DE4=3DBB=3DB6=3DE5=3DBA=3D95=3DE5=3DB1=3D82=3F=3D?=
         =?us-ascii?Q?____=3D=3FUTF-8=3FQ=3F=3DE6=3D8A=3D80=3DE6=3D9C=3DAF=3DE9=3D?=
         =?us-ascii?Q?83=3DA8=3F=3D?= <machel@vivo.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Taku Izumi <izumi.taku@jp.fujitsu.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>,
        "ttoukan.linux@gmail.com" <ttoukan.linux@gmail.com>
Subject: Re: [PATCH net v4] bonding: Fix error checking for debugfs_create_dir()
In-reply-to: <47eb92888fa46315214ad921a9ac45b695355a36.camel@redhat.com>
References: <20230719020822.541-1-machel@vivo.com> <47eb92888fa46315214ad921a9ac45b695355a36.camel@redhat.com>
Comments: In-reply-to Paolo Abeni <pabeni@redhat.com>
   message dated "Thu, 20 Jul 2023 12:20:01 +0200."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date:   Thu, 20 Jul 2023 11:22:26 -0700
Message-ID: <25152.1689877346@famine>
Precedence: bulk

Paolo Abeni <pabeni@redhat.com> wrote:

>On Wed, 2023-07-19 at 02:10 +0000, =E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=
=E5=BA=95=E5=B1=82=E6=8A=80=E6=9C=AF=E9=83=A8 wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in bond_create_debugfs() was forgotten.
>>=20
>> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding d=
river")
>> Signed-off-by: Wang Ming <machel@vivo.com>
>> ---
>>  drivers/net/bonding/bond_debugfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bo=
nd_debugfs.c
>> index 594094526648..d4a82f276e87 100644
>> --- a/drivers/net/bonding/bond_debugfs.c
>> +++ b/drivers/net/bonding/bond_debugfs.c
>> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>>  {
>>  	bonding_debug_root =3D debugfs_create_dir("bonding", NULL);
>>=20=20
>> -	if (!bonding_debug_root)
>> +	if (IS_ERR(bonding_debug_root))
>>  		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>>  }
>>=20=20
>
>Does not apply cleanly to -net. To be more accurate, the patch is
>base64 encoded and git is quite unhappy to decode it.
>
>Possibly your mail server is doing something funny in between?!?
>
>Please solve the above before reposting.

	It appears to have trailing carriage returns on every line after
base64 decoding, i.e.,

$ git am /tmp/test.patch
[ this fails ]
$ git am --show-current-patch=3Ddiff > /tmp/patch2
$ cat -v /tmp/patch2=20
---^M
 drivers/net/bonding/bond_debugfs.c | 2 +-^M
 1 file changed, 1 insertion(+), 1 deletion(-)^M
^M
diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_=
debugfs.c^M
index 594094526648..d4a82f276e87 100644^M
--- a/drivers/net/bonding/bond_debugfs.c^M
+++ b/drivers/net/bonding/bond_debugfs.c^M
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)^M
[...]

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com