Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9985846rwp; Thu, 20 Jul 2023 12:46:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlHADc3Pls8eIqzeNLf5E0N70qbLlJ49hMhsqrcf+Nvl6FU7tsIc24QjMLnST1p1rEVqVfvk X-Received: by 2002:a05:6358:89e:b0:139:4822:4c6b with SMTP id m30-20020a056358089e00b0013948224c6bmr1952116rwj.19.1689882362712; Thu, 20 Jul 2023 12:46:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689882362; cv=none; d=google.com; s=arc-20160816; b=fO2aPWvRi0s+ebcWAs+RkKMiv49Ct+t4iklHK79BmPffxnJ3EqiTNYhbL44KR3qMHM zNh14WI5b4f0diLwGg7oGopHKiMw+VMH6P+eUE+H38LHmOGYdA+hPIXny539qgYDAjGa kDhNfVB/Jc4f1cq7mjTtP5DpT2TtNB+CWJP6XqiYAKM2gS8R+Xrv1Xw0o9Lm/APJNo0B +D1k65gQSWbh+Mq8/cGsceg6kN58bqXsO2qcXq2Jme4jAeLUgQGcaVhUnbD/HgYAtSEr R7gR3qHnIaOFhWZEtWHNxJ+sWeFwNLVgZdygPtmTpjO+GJ4sZobNjwbozHB1Xc9tg8yy +OzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:reply-to:user-agent :mime-version:date:message-id; bh=OofU4N2gm217xXDz0vMewiE0sBhu2TW5jXEMo/pc6Jk=; fh=a0GYDhB/RWhNXW973GEQ5RZ7zi5Zo+wRyaViS9Ch6A0=; b=CSk8c5qy5fLeg4ndE8eYeRPSXEL/9+8iZpPF3wEy1M/Kwjl8qSEQmOsRfkPgODdlgn YM9VMCTl/ZfP8nXP78KZuNyYiuI6PP/zEYnlHnwppMuHids5IkIvcU1KKn70YL7YrjTe 1i9PsfT+ZzIl34jVmrXoM2wLIhIkOI6e07AEiVzq9FyMLJeeiIE9d7ncIzlgOcu167zY 9Tj//IMg2CsIrOLg7Y20dVgL78zXpYRvDH4xPrd3zGQm8AbiXA4XcCleokwdySRLjxo9 9vscG2y26T/Sta01QIFV4doRhgFu3NsNQWCaEeVWRwCl28QjihM3kWABL/COFyH95hv8 mtyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a635905000000b0055070c6da5bsi1254555pgb.670.2023.07.20.12.45.50; Thu, 20 Jul 2023 12:46:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbjGTTYO (ORCPT + 99 others); Thu, 20 Jul 2023 15:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjGTTYM (ORCPT ); Thu, 20 Jul 2023 15:24:12 -0400 Received: from mailout.easymail.ca (mailout.easymail.ca [64.68.200.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1B7171D; Thu, 20 Jul 2023 12:24:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 479C0623ED; Thu, 20 Jul 2023 18:48:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YkMMq7FPWqRc; Thu, 20 Jul 2023 18:48:49 +0000 (UTC) Received: from mail.gonehiking.org (unknown [38.15.45.1]) by mailout.easymail.ca (Postfix) with ESMTPA id C8ABC61E38; Thu, 20 Jul 2023 18:48:49 +0000 (UTC) Received: from [192.168.1.4] (internal [192.168.1.4]) by mail.gonehiking.org (Postfix) with ESMTP id CC21F3EED6; Thu, 20 Jul 2023 12:48:47 -0600 (MDT) Message-ID: Date: Thu, 20 Jul 2023 12:48:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Reply-To: khalid@gonehiking.org Subject: Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies Content-Language: en-US To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller , Javier Martinez Canillas Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Linus Walleij , Matt Turner , Max Filippov , Michael Ellerman , Nicholas Piggin , Palmer Dabbelt , Russell King , Thomas Bogendoerfer , Thomas Gleixner , WANG Xuerui , Wei Liu , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-2-arnd@kernel.org> From: Khalid Aziz In-Reply-To: <20230719123944.3438363-2-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/19/23 6:39 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc codebase, but > the merged arch/powerpc never did > > - arm lists footbridge, integrator and netwinder, but netwinder is actually > part of footbridge, and integrator does not appear to have an actual > VGA hardware, or list it in its ATAG or DT. > > - mips has a few platforms (malta, sibyte, and sni) that initialize > screen_info, on everything else the console is selected but cannot > actually work. > > - csky, hexgagon, loongarch, nios2, riscv and xtensa are not listed > in the opt-out table and declare a screen_info to allow building > vga_con, but this cannot work because the console is never selected. > > Replace this with an opt-in table that lists only the platforms that > remain. This is effectively x86, plus a couple of historic workstation > and server machines that reused parts of the x86 system architecture. > > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Signed-off-by: Arnd Bergmann Reviewed-by: Khalid Aziz > --- > drivers/video/console/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 1b5a319971ed0..6af90db6d2da9 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -7,9 +7,9 @@ menu "Console display driver support" > > config VGA_CONSOLE > bool "VGA text console" if EXPERT || !X86 > - depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \ > - (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ > - !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML > + depends on ALPHA || IA64 || X86 || \ > + (ARM && ARCH_FOOTBRIDGE) || \ > + (MIPS && (MIPS_MALTA || SIBYTE_BCM112X || SIBYTE_SB1250 || SIBYTE_BCM1x80 || SNI_RM)) > select APERTURE_HELPERS if (DRM || FB || VFIO_PCI_CORE) > default y > help