Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i51094778:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
Mime-Version: 1.0
Message-Id: <f176c331-f8cf-4a44-8ada-7d9c958b17ca@app.fastmail.com>
In-Reply-To: <20230719222033.117513-1-minhuadotchen@gmail.com>
References: <20230719222033.117513-1-minhuadotchen@gmail.com>
Date:   Thu, 20 Jul 2023 20:53:26 +0200
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Min-Hua Chen" <minhuadotchen@gmail.com>,
        "Hector Martin" <marcan@marcan.st>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
        "Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>
Cc:     asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static
Content-Type: text/plain
Precedence: bulk

On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
> This patch fixes the following sprse warning:

typo: sparse

>
> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 
> 'apple_dart_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---

Acked-by: Sven Peter <sven@svenpeter.dev>

Thanks,


Sven

>  drivers/iommu/apple-dart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 8af64b57f048..2082081402d3 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1276,7 +1276,7 @@ static __maybe_unused int 
> apple_dart_resume(struct device *dev)
>  	return 0;
>  }
> 
> -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> 
>  static const struct of_device_id apple_dart_of_match[] = {
>  	{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
> -- 
> 2.34.1