Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4eb0162-d303-b17c-a71d-ca3929380b31@amd.com>
Date:   Thu, 20 Jul 2023 13:26:20 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the
 command waiting loop
Content-Language: en-US
To:     Jason Wang <jasowang@redhat.com>, mst@redhat.com,
        xuanzhuo@linux.alibaba.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, edumazet@google.com,
        maxime.coquelin@redhat.com, kuba@kernel.org, pabeni@redhat.com,
        davem@davemloft.net
References: <20230720083839.481487-1-jasowang@redhat.com>
 <20230720083839.481487-3-jasowang@redhat.com>
From:   Shannon Nelson <shannon.nelson@amd.com>
In-Reply-To: <20230720083839.481487-3-jasowang@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RCtBOWd0MGJRUmkxTCtDay80SG0vQzQ2cHdQdGFTQzZQZjd4SDNUZ09IRzd0?=
 =?utf-8?B?Z1Y0YmFpQ01QTUpDZytnSUtMOU5na3kvMTVnVzcwM2p5Y2FFcW5BRzlZOGdP?=
 =?utf-8?B?Smp1Ry9PVk9QNGM5UUYrZGVjZEFPUkg0bG9mWlR5YnkwQ3JFM1Vpd0tob215?=
 =?utf-8?B?NFN1YVlQRW1QOGRyMTVxRWh1YUNqTGZSTGcreGdPZDdvVU9KQ1EyNDVsWWpa?=
 =?utf-8?B?ejJnc09oTklkeCtNeFdwbnJvWkludFhlUXVZU0xKUnZFTEhjSGlMUWtDUDA2?=
 =?utf-8?B?R3NUMWFYbmhFUlJKRERBV09QYXIyaU1RNnh1SEx2OXl2WGNvQlNNTlNyakU0?=
 =?utf-8?B?UTA3WnFTVURIUWI3TzNaZ0F5YkQ3cy9yS0xWbEh4S0JiVnpnUFpHbSthL1dt?=
 =?utf-8?B?WDFBOVYzRmcvbWJrd0M4VHZVaXpVSGovMWpyTFJKeGpUSldLN0l3azhTS3pt?=
 =?utf-8?B?d0czYndIYzFVRitvQ0p5MEZoMHBKZm14RVFEVFJuQTBXWFZLMVlFdDY5SnJ6?=
 =?utf-8?B?Vm5WbGUxTmNqKzEvRHNwSUN3TitFL29HNVRLcHNsbFBBSlR6dEl1VGZ3S3R5?=
 =?utf-8?B?anQzakJybnhVK0ZKbWo2UDhXTDloK0VqV0MxQ053cHUzMEZ3Njh3TUZCajBG?=
 =?utf-8?B?TEJjbE1PRkE4dmc3a3l5Z1g5b1VpNjlzUGtnYXlrVjdGMVl3MWdnK2QvQzhO?=
 =?utf-8?B?Rmh2NWc1Yk1iSmd2b004d0pTNkJtcE1VajZ1Mm5nM0ZHdzY5Q1JrMis3QUx2?=
 =?utf-8?B?RHNLWGNnOW50RXQ1Q05EU1FoZFhtYlM3dVI1bVd5Y0hPQzd5Tm1KSUJxRUpK?=
 =?utf-8?B?ek5nR0c3dXVRclVBdzZYR0gxV21TMCt5U09NQUVIamFreWFDVDdsL3NNSVlx?=
 =?utf-8?B?MVBISUF3aTQwY2dMNEdwQXVLWGhPbFQvWm1TWVpzRHV2bXBYRDJrZ29qMlFB?=
 =?utf-8?B?Qnl0L1JpNEttaVBGaDJSSFd0cjMvN1hJaWZOVktqRGFtK0dDRUdtSmpseG5x?=
 =?utf-8?B?WmY3dlFtTFlOeWxYSDF4eiszYjExRFVCRUt0VlNFdklGV3lTYlQ3NGJQdEVu?=
 =?utf-8?B?M1llNnBBVXZ1cEhBMlRBRnhTZXRETDgxalZCTjVsNnJyb3Z0WVVuUndqNXg1?=
 =?utf-8?B?bDdpaVZWdkkwVkRidERLZk1ER2VIQVR0V203VFFjUTg4enBwMVNpSy9MMkZy?=
 =?utf-8?B?WlI4UkdUS1VSVW5NVnNvSGxsblprUHlRMEJCcVpscmcrL3NxSm9Bdm5oTHp3?=
 =?utf-8?B?YW9BWFRtVE5jQ2pBSHphRHNVRGdQdEZ0WW42ejNlaHJlR1Fwdk81V05tTEpY?=
 =?utf-8?B?bGM0MStaQkJIeGQ0QTk0Q3RNUzFKRjViWGowYUhRd2dqRDB0MEsyTnVMZzMw?=
 =?utf-8?B?bTUzOGhMUEF0aGdhQVk3TjNkQ1RVRTlXWWlhYkpSemdiMGw0bGg2SzFCNjNv?=
 =?utf-8?B?Zmw1YXBsaUE2MExVcWdvK3dPcVE4M0NVQVhJUmtCTkRJakdKQzUzMTR6ZTB2?=
 =?utf-8?B?SmxuOWxmRzd6S05TNDRtZVVLam5jTmx3OFRieDVLUjFwMGtuUGw5d2l3dGNm?=
 =?utf-8?B?NlY1MURnbGo3eUZoVFUydkJFcXhGRzBFN2piMFZvdFFhc1dkVDJ2UWQvV3ph?=
 =?utf-8?B?d1d3Z3dvUXMrQ2pRcS93RElUMWlCa2dWN0VzK2RsN1NCak4wSC91SUkwMG1E?=
 =?utf-8?B?UmFxclZUaDhkaEYvQXFDZFRKbWwzU2lEWmdXZkd5OWV5VHU0OE54U0h2VW03?=
 =?utf-8?B?OTMzc2J4SnhsVm5aSmF0RE95ZldDMXlZcW8wU3pBdFJ1VFpxaEpBU1JlYjFB?=
 =?utf-8?B?THlCeGIrbTROMWQvK200UmNYVzIxUWQ3TTZVcEZBYTdraXgra2Q4SXVLNXJB?=
 =?utf-8?B?bU93MUVGM2QrMm5LcjhiRFlCb0ZjM0s3R05sN3U2NWZ6VnpyOUFQb3lHcVRo?=
 =?utf-8?B?a2FjWStZSVRmWm0ydFplYlJtQlVrZmI2aG54NnVpMjFFa0pKTjFRMSt3bkh0?=
 =?utf-8?B?bnBDOEEvR0tPTWYzQzRDQXdnVXJxNVVzVEJiWGphN2lDR3NYSHNDUDRMeDU3?=
 =?utf-8?B?RzExT3hoLzV0ZG1VZXBzS05DSk5BOHBKbnVLbVBOOWNQRHRiZC9PY2NGTXdW?=
 =?utf-8?Q?dnqLQ6BC8JLaQynbBPHZLXZZI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c188d924-09b7-4cec-6f0f-08db895f95c4
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 20:26:23.2095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vT5X6xvLQT7JtfjsQLkaEiyC2reEiYICzLcp2N9njr0qNNti0UjokJ0m0LUqNg0E3WD//LspHDMYFftplXq7+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5424
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/20/23 1:38 AM, Jason Wang wrote:
> 
> Adding cond_resched() to the command waiting loop for a better
> co-operation with the scheduler. This allows to give CPU a breath to
> run other task(workqueue) instead of busy looping when preemption is
> not allowed on a device whose CVQ might be slow.
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

This still leaves hung processes, but at least it doesn't pin the CPU 
any more.  Thanks.

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>


> ---
>   drivers/net/virtio_net.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9f3b1d6ac33d..e7533f29b219 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2314,8 +2314,10 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>           * into the hypervisor, so the request should be handled immediately.
>           */
>          while (!virtqueue_get_buf(vi->cvq, &tmp) &&
> -              !virtqueue_is_broken(vi->cvq))
> +              !virtqueue_is_broken(vi->cvq)) {
> +               cond_resched();
>                  cpu_relax();
> +       }
> 
>          return vi->ctrl->status == VIRTIO_NET_OK;
>   }
> --
> 2.39.3
> 
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization