Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 14:02:06 -0600
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Lars Povlsen <lars.povlsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        UNGLinuxDriver@microchip.com,
        Daniel Machon <daniel.machon@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [RFC RESEND v1 pinctrl-next 1/1] pinctrl: microchip-sgpio: add
 activity and blink functionality
Message-ID: <ZLmSvkizdykGGpv6@MSI.localdomain>
References: <20230712022250.2319557-1-colin.foster@in-advantage.com>
 <20230712022250.2319557-2-colin.foster@in-advantage.com>
 <CACRpkdYXeGq2LnD+bpAXm82Aa-Czob8afQSfjfMFweBLhdr9uw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdYXeGq2LnD+bpAXm82Aa-Czob8afQSfjfMFweBLhdr9uw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTA0NTd0aDZPMzZRbEdsa2xQWXphUkFuVElhb0lKY2JUaWdXQzJKb2NJT0d0?=
 =?utf-8?B?ZU1FLzdBQ1l4M1ArTkVWZ204QW51aU9udVdKOXV0Tnd4eU5ieUlQeVdjSDAz?=
 =?utf-8?B?cUVvejU0QnN4bkpaU1NueHJDUTNxakpkRmpmcjNFUHlGeFk0MVhYMWtXVUdL?=
 =?utf-8?B?VHp4bUxXMzRPOTE4RTZyUGI5RjVEL3hoZVRuc2JHbU1iK3VjenY2WTRyK3JI?=
 =?utf-8?B?ZjJmV1pLdHF5MGFFU1VrQTZVTi9hdmFITGN2SjVvb3M3ZXdXUXdhMWZKR1Jj?=
 =?utf-8?B?SDhuRCtCOEZic25UczMwYWcrMDRtYmE1THh5b3pjSGtYM3UyOElkSHNOMDNB?=
 =?utf-8?B?b3BWZzVDS0Qwb0tBODI5cXZ6QWFWVkVnWHhBaGhTMWROdWdWc1JPMFN6R1Nv?=
 =?utf-8?B?QXJYTWQ1Y2FQdkUwZGlPSzFGdTlPNEFSZzRXS1RZL1pHRWcwcElncFk3amJF?=
 =?utf-8?B?ei9uekVUa1NMMEloOU1kU0hPeDhQTi9QQll2SGQ0Q3RYZjdzNmlpUWtGMkhD?=
 =?utf-8?B?ZksxTTJhTEJ3cnRPODdqUTZuZUhRYzQvVzZ6RlRVMVJZVGJZQ3pBemgyckdj?=
 =?utf-8?B?ZDIvbzhqSkw5VUtkbG1sTS9yZzlxK01VcEhNYWhkWXVDQXB6aTZqN3NCbEp3?=
 =?utf-8?B?OHJ2UUlUdHI5SmpKRFRxQ0w3Qm5mRHlBWTBwcTFYN3BhdVRKS0lmakZrL0dK?=
 =?utf-8?B?VDFzSEx4RW9uU1RtVzRCMkNpU0pLeVQxenNCaFlZZzRnRWVCRE45WVVmQkQy?=
 =?utf-8?B?amo0Ui9IQmNTTmJ5WmR0RWVKOGpWVWx2b0NzZ0I4K1JtR2kzS0RJLzBFSjdu?=
 =?utf-8?B?NXE4aUZwWXFoWmdlbngyVW9ad2w5Q0ZpRjN1TkVxT3hUbDBWZWxZRFpkWFFR?=
 =?utf-8?B?WWZoME5BeHBqT1hQVTQrNGVteDlvZ0ZNT0dpcFBTeHVjems4MUhmS2JJSmly?=
 =?utf-8?B?QWFacDZ5Z3N2YUxxNkxIUnllZitsMHBETU10MGhtMEU3SXpodm9CNUt2Q2Yv?=
 =?utf-8?B?SjVaR1VKSXpjekJpVTZ2ZElBTi9MWDVLL3RvZ0pkeEJHU1BCcG9LekEwQWwy?=
 =?utf-8?B?MjhsZHRLMG5QeGdMVFNwUTlWQW1Bb1doZFZmU0lYOTNSdkJ6bGlMWkNyOHFu?=
 =?utf-8?B?czVlR09KTTJEb1duQytySnU3RnZhSU5QTVFPYlRpTk8rS0lxa2kyd3IzNklQ?=
 =?utf-8?B?a3ZoYWFHZWtHeFV3N0JuQ05CZ01wdFdKSEFRalJtRmEzaW9WK1QvZi8xc0JE?=
 =?utf-8?B?OVBNcXNjWE83dnU0Zk1zZHdHN0xqOHIvMXNycUVjY0VTRW9ZTm44ZDBSdWRo?=
 =?utf-8?B?R0lvMWlqaWhFeDJtUzZCcTgyOHhFMjVCWGJKdUN4SjY0S3JXR3BGeFJ5QmhK?=
 =?utf-8?B?ZzhpNTJDak5rU3dxT1lxNTdvQTBUMzh5cjBScWRSOWJOeFNFaW5mLzlDWUsv?=
 =?utf-8?B?c2l6SEdRbklMdFNsbU9QRTlBZWtVdUYwTDJCYnBGeFJsUG1VWE1EWWkzUXN5?=
 =?utf-8?B?VlN6ZWIrRUFiNmZtMDhiR2hrRkNDZ2UxK2RNc08vdHNrd0lQN3pULzlNR3Qw?=
 =?utf-8?B?dkRnbnc1eXJHa1VtaUY2SDVuSlNqOVFoK2VhUnJXVE51U1hzLzh6MUltaC9X?=
 =?utf-8?B?SzBCbVNSeWtjUTRsUFd1aFZGbk9ZbU1VN3JYMXVSUWZ5V0lOSERMWXdnM1Fv?=
 =?utf-8?B?MjhxVWVESFBoMXBnSU1LOHhodklzd01YWXdZenpzVU9DVWQ0OEZuT2wxZmxR?=
 =?utf-8?B?dTc3NkREcFh2RStlamk2Q1VicG10cnpWU0VvODFnVUJzNGRFcmdBMEV2U1Ny?=
 =?utf-8?B?NGQ4b2VnM1l6R3B4dGk0RkpLR1p0Ny93eWl0blRKWDA0NWVQTkN6azRiRXNZ?=
 =?utf-8?B?TWt1TGg1MWVHMW9TbVE2UUVrVFdOWVg1blphK3JPYVljYXh0VGM4d2o1NFow?=
 =?utf-8?B?VUxyWlk2cTZDcWhvTTQwa2xlb0JENFliZ1NBeWMrOHM1VUowbjNKanp4NzRT?=
 =?utf-8?B?MzVCNUwzb3NZR2VTdGd1YU95TG81VkxVQVlJcFg2OENOdnJyV3p4SWdpY3Bq?=
 =?utf-8?B?Mk5TcDR6N1I0aVpnTWFPcW9vdnpOM0ZQSmNvRUV3MjFKV0s2Mm1UakwyT2x1?=
 =?utf-8?B?cFdtMmRmR1ozM2p5R21RZ2IrcHJjczVIOFhaRTJuKzRSL3dyK3pzaFRsSlNx?=
 =?utf-8?B?Nnc9PQ==?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: daa96efc-e09b-45d6-e1c5-08db895c33eb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 20:02:10.6821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n77pLPw5SYEaFCPt/kbtcwV34pHlGo9AOPF/+uYUVwo+WaI7QSljSliy1+DT/yJ+abAwLhnhWicsQvRu7uAaugmOWKoxiAojUM5mjthGx/s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6065
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 20, 2023 at 09:25:32PM +0200, Linus Walleij wrote:
> On Wed, Jul 12, 2023 at 4:23 AM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> 
> > Add additional functions - two blink and two activity, for each SGPIO
> > output.
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> 
> Could Lars or Horatiu review this patch? You guys know the driver
> best.

Agreed. Please don't merge this without their approval and hopefully
testing.

I did demote this patch I've been dragging around since 2021 to RFC
status because I'm more interested in making sure it will fit in with
the work on hardware-offloaded network activity LED work that's being
done. I took Andrew's response to the cover letter as an suggestion to
hold off for a little while longer. I can be patient.

Also, this RFC was two-fold. I don't want to duplicate efforts, and I
know this pinctrl driver was written with this functionality in mind. If
someone out there has a hankering to get those LEDs blinking and they
don't want to wait around for me, feel free to use this as a starting
point. I might not get around to the whole netdev trigger thing for
quite some time!


Colin Foster