Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10131341rwp; Thu, 20 Jul 2023 15:20:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlGf/w8ykYePNKUTWDaqG+Mi4CveW6j7BTddbmCPcJ6+OpGLPi+SlEvnztAJJKUhAtNkbRXH X-Received: by 2002:a05:6402:5150:b0:521:dd30:f153 with SMTP id n16-20020a056402515000b00521dd30f153mr115015edd.40.1689891628782; Thu, 20 Jul 2023 15:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689891628; cv=none; d=google.com; s=arc-20160816; b=XNtJfQPxmpxem+QASt7iCKWgWrX6vVLptwwXOhOO5iXPrv4fGYzg5CcwSeBNW876uX y9u/TWPhdixQWa+nk56R5sSwB/Q67s6f2sUmnDeMZUSK6YIgcVuarnN2qbjkCNnHubWb pf5qYHtir2bi7qj3dhkTD/nDU8PMEbKIt57DeQI3Xz6Z0WH0moHnUXAYSbZT1lbDkwTa zznK8eimWyvWRwKPIRToC9nOPszwfOTNpfO2zBOWh5DbvaJdGV/KiHzfW2CLq6el6tGk FAbIpFjDz0WOkhME7ZlKe4GABVmA4z+/Wf2qKFTtEWAmE3jza63T8lfLLYbev0J8aCBc SMjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=twEvmkPU0mxcvyzF5PqdNe8AyZ4NwFNYaQ1CTqmcu+E=; fh=k/Zg6rGhCMzmYxvnVhxaugB6SeIgJzTyBD8B6bYXwww=; b=zykAQJgdZe7EUOWOS098woq2FVziPEGNHVxX+WctY+cq0ucQWuoha6dKp9CZyb3KPG I9cOjP6gLLrPUXBho3L8AtEeAE0PYs6HbCMIBM/cdJ6nLmwqLzgvNraifezzUNp5LxOd vKo2RJrHRZQnlMPWiz9j3i/iYIreSaelSC9D81pdTB5oUD33WQp4PVYT/hlM/CrCAOtT lR7hws7+2llkPfzzugQmBU3D8fprzJFeZvn5lOYHRwyCT3491hCswn4Z51Qbm7gEGkjH fbNVg9uaeZmtk4AOvZa1O0L7ddfXEe/EarvaxvkzHRYdDNslTpGpqjuRXq0pnok2gp1/ jbog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=No5VDdWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a056402088a00b00521d0dbfa04si1344020edy.686.2023.07.20.15.20.04; Thu, 20 Jul 2023 15:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=No5VDdWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjGTVsC (ORCPT + 99 others); Thu, 20 Jul 2023 17:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjGTVsB (ORCPT ); Thu, 20 Jul 2023 17:48:01 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860B71719 for ; Thu, 20 Jul 2023 14:48:00 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-52cb8e5e9f5so926948a12.0 for ; Thu, 20 Jul 2023 14:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689889680; x=1690494480; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=twEvmkPU0mxcvyzF5PqdNe8AyZ4NwFNYaQ1CTqmcu+E=; b=No5VDdWPDUvfW7+NJOwgoJQDfOD+IhbiqUf5oJwIfT5+B0/WTewqNZPzRdC+JgE/lP kjJjektXdbhx3MC2con9lxGY6jtKJu4fUqeSH3TvDBcAMLaRTxOfTxMfNZ8F4mxf+mDR KAea+ZtWfUbezLnbGHamUG+Wo9A/RULPP2LYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689889680; x=1690494480; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=twEvmkPU0mxcvyzF5PqdNe8AyZ4NwFNYaQ1CTqmcu+E=; b=C1xhJcBk7xVcSqm6YwPoZKKBDnXgaXgX8zB/W0d7Ljk1kUtO5lf8AGkcKCgXe0v5vZ n8/x040p0gAd5lcDlqLM4/hDxOwoIV8aBiqKfn1yE+sexwVm9i01hEr/7E15uc3l96JC g7Gknnmy0TNBtRG6QJSRj3FV2Qexn/rRCxj2ZNwj4scfx7d2YMrtZIjnS1vmViK1ZLiZ tC3jNe5bj4UAj0bXhO/4DOq6uLrWei5I0vQ6mqIdR6SLy8c0NhaczuVTqZt5XkzlJkHM 7631o5jKZUdPacioT4AbcXzJA7w0/KbFE4YZ4W+Ogbo8IegCXjyZrrziKoMcAbINUKuR XjZw== X-Gm-Message-State: ABy/qLYNsUO2upicgQkdRSQ0trD3LVgdu8wG2L1KAmk5pIf+1aWzRCKC WkS6joGdHFy0mu1D10vLDOcw3g== X-Received: by 2002:a17:90b:118e:b0:262:fe4b:b45 with SMTP id gk14-20020a17090b118e00b00262fe4b0b45mr171679pjb.19.1689889680021; Thu, 20 Jul 2023 14:48:00 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id lc14-20020a17090b158e00b002612150d958sm3082786pjb.16.2023.07.20.14.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 14:47:59 -0700 (PDT) Date: Fri, 21 Jul 2023 06:47:55 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , stable@kernel.org, Zubin Mithra Subject: Re: [PATCH v2] media: uvcvideo: Fix OOB read Message-ID: <20230720214755.GE57770@google.com> References: <20230717-uvc-oob-v2-1-c7745a8d5847@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717-uvc-oob-v2-1-c7745a8d5847@chromium.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/07/20 17:46), Ricardo Ribalda wrote: > > If the index provided by the user is bigger than the mask size, we might do an > out of bound read. > > CC: stable@kernel.org > Fixes: 40140eda661e ("media: uvcvideo: Implement mask for V4L2_CTRL_TYPE_MENU") > Reported-by: Zubin Mithra > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky