Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 23:23:46 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     corbet@lwn.net, Andrew Lunn <andrew@lunn.ch>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Leon Romanovsky <leonro@nvidia.com>, workflows@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux@leemhuis.info, kvalo@kernel.org,
        benjamin.poirier@gmail.com
Subject: Re: [PATCH docs v3] docs: maintainer: document expectations of small
 time maintainers
Message-ID: <20230720-mace-dipped-3bd066667b3f@spud>
References: <20230719183225.1827100-1-kuba@kernel.org>
 <20230720-proxy-smile-f1b882906ded@spud>
 <20230720143746.1adb159a@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7E5noNPs/iMecJG0"
Content-Disposition: inline
In-Reply-To: <20230720143746.1adb159a@kernel.org>
Precedence: bulk


--7E5noNPs/iMecJG0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 20, 2023 at 02:37:46PM -0700, Jakub Kicinski wrote:
> On Thu, 20 Jul 2023 16:15:26 +0100 Conor Dooley wrote:
> > ..I noticed that none of these sections address actually testing the
> > code they're responsible for on a (semi-)regular basis. Sure, that comes
> > as part of reviewing the patches for their code, but changes to other
> > subsystems that a driver/feature maintainer probably would not have been
> > CCed on may cause problems for the code they maintain.
> > If we are adding a doc about best-practice for maintainers, I think we
> > should be encouraging people to test regularly.

> I think our testing story is too shaky to make that a requirement.
> Differently put - I was never able to get good upstream testing running
> when I worked for a vendor myself so I wouldn't know how to draw=20
> the lines.

I'm not saying it needs to be added as a must level item, some words to the
effect of
  Maintainers should test the drivers/features they are responsible for on a
  regular basis, independent of patches that modify their area of
  responsibility. This helps ensure that changes to other parts of the kern=
el
  do not introduce regressions in their driver/feature."
would suffice IMO.

The doc as it is is a useful addition though, so you can add a
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
if you like.

Thanks,
Conor.

--7E5noNPs/iMecJG0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLmz8gAKCRB4tDGHoIJi
0pN2AP0Xd2XBsDNncFbZ2tU2esaZm61Bv1Qm8ravumVaJPp4aQEAp34+tM3RtH9V
grQF54xOH05cBTHFkohiAdRN/PILXww=
=E5Ol
-----END PGP SIGNATURE-----

--7E5noNPs/iMecJG0--