Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10184766rwp; Thu, 20 Jul 2023 16:22:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlF2Gpdqddkhwzym8qNVCxRTBIYne5fPa6zEh+BrfJ1REesISsUyh+485YO+23rWi5+q9NL9 X-Received: by 2002:a17:907:b10:b0:993:d1b6:61cc with SMTP id h16-20020a1709070b1000b00993d1b661ccmr154714ejl.44.1689895372363; Thu, 20 Jul 2023 16:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689895372; cv=none; d=google.com; s=arc-20160816; b=Yi6iU1tdlPk5RLTuM6z7D/puq+pz1+NXmeF6QGl7lAba8kZ28YnLTTLQbMu+0PmOge FzvGl9pe44oO2WVq5ZMYuM9B3ku5PEcRLq1vxRoJ10yZ3Pu37vH5M7GomM1vi7+MXZil 6K3Vsb4qUFXRBg6mDu8qtJT4/nUMN+l+biYQN8MuCNRwMfWSnFhxARH3YLNTOnGEz/4q NZ4LCvI47aFuHZVABKRET5PbjkcqlXKDXNckuQqo/Rb3JG91drSVjVdQP+7um81lXTtY izyFDAMeUGJqyU0eP5Y9B8n0zto1gl5okh4XpCtkkqeA/CKn2Hjwn0jWVBMOeo1JkPpN gaCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GnoTCF2aB/aSqWAJBLGbR4gHlscBgYaA7yXEbb2wyGE=; fh=VYUvNHWwRhArRb7BdFa1NXGXvY7mXGhB0yCZGNknZVc=; b=B+ORMlyJHzhzg23ZRntZHopWPcLiTaMBAVHG3638BnxP2E0TUtQvp0Deit30xWEl5L Ct882g5zwX7/Vw2SlOWtMRlso/d+GVIcc6g2Gp43GRfSVzrPoG5WfXwvzjKpxYJPXGtP yHzeofrcAGR7RJxABPNpZqx7QBCOVT2wJYaXelGlNOmlHT3s3c8JiMVKcBw907504rri 3y0RFAhDEGLxnH/Bpjv6cheCeVjSrrdp6K1UoquwJhHT5LOfmGueNUYkv5Uv1qUelIsO J72ihwPWZ8aBDqrDXRtXXGYXn7i+3VyDz24fRlSDR/DmqqskX2i1JPd+vw2/NVTecwny uWMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b="Q0st3/uu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pj25-20020a170906d79900b0099367350a8asi1347555ejb.899.2023.07.20.16.22.27; Thu, 20 Jul 2023 16:22:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b="Q0st3/uu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbjGTWTg (ORCPT + 99 others); Thu, 20 Jul 2023 18:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbjGTWT3 (ORCPT ); Thu, 20 Jul 2023 18:19:29 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D105E2D4D for ; Thu, 20 Jul 2023 15:19:18 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-785d3a53ed6so17475539f.1 for ; Thu, 20 Jul 2023 15:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1689891558; x=1690496358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GnoTCF2aB/aSqWAJBLGbR4gHlscBgYaA7yXEbb2wyGE=; b=Q0st3/uuG+jmslAaSSiW1B/Bh02MVEa8TbQgCgFVQqY2UOskLaiChfSXbE5u306RwE /1d8d7kO9+BLFVoQ/IsCvuamQmixezGP3fpL+Yqa3RGQE4S/Kr7iJMXWM7bi9xbHPbiB NU10/v4EYu6lYpP7RWP49FgU3SPYyDh0n0tYDQe8b7cLIlCr0pXANH7grAtV6JM4MV6Z HGnyq4VGdfAUyoDQAEq2+pZ6tHwiBHBD7M3Eupp00m46BKov5Ezh+ANgfhYO4Cx+/lxl /OrUNy7KLxAyyN4H0pC1Q3WmysodwCXsAhUZGu/a+k5HT9GfGdDKclTggq6wLbeZRcPB n8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689891558; x=1690496358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GnoTCF2aB/aSqWAJBLGbR4gHlscBgYaA7yXEbb2wyGE=; b=iGLZ3KhOEhNJXf9sYBxnf4jKBHwCL3XJU9tfZY59b3y8Qk0P5NB7k3JNS2nJbgw6GZ rmoQIYa2jFNSi+6cEdfbguCm0XfFo3e5SlTObN7fPkjqbSyHsnAGnalJu7BtaZG9WyYj t+PADVhF3K1+L3p37cZiUzQx5FJ0d18P/zaJF/zQi1S7L3bnNP1qzUgCywKC9wPidwm3 0E3oWeFkFrl1jiV5DGc9O7Ph2DQx7X0ZHoKXW3xO5T5TuaJnmCCHcYjgEmX1J5ciybuA Oo0+O2DZNR31FV6fNuyO+Fw298MJFRbBjVonrf4LI9YIWHG0cB/DJnqusX6mDrAzoJrS edmQ== X-Gm-Message-State: ABy/qLbNaZCe7bZtmsQHAFmAzZwmUC7+B8fz7QtEuJ7ltB6PsNlxBeNV 7JI+M1kX1qErwYPGkrBxD//s0wN+/MQSiXJmQaQ= X-Received: by 2002:a05:6602:14d2:b0:783:6ec1:65f6 with SMTP id b18-20020a05660214d200b007836ec165f6mr184768iow.1.1689891558118; Thu, 20 Jul 2023 15:19:18 -0700 (PDT) Received: from localhost.localdomain ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id q1-20020a63bc01000000b0055b3af821d5sm1762454pge.25.2023.07.20.15.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 15:19:17 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: peterz@infradead.org, andres@anarazel.de, Jens Axboe Subject: [PATCH 08/10] futex: make futex_parse_waitv() available as a helper Date: Thu, 20 Jul 2023 16:18:56 -0600 Message-Id: <20230720221858.135240-9-axboe@kernel.dk> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230720221858.135240-1-axboe@kernel.dk> References: <20230720221858.135240-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To make it more generically useful, augment it with allowing the caller to pass in the wake handler and wake data. Convert the futex_waitv() syscall, passing in the default handlers. Signed-off-by: Jens Axboe --- kernel/futex/futex.h | 5 +++++ kernel/futex/syscalls.c | 14 ++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h index 292224816814..3536d21adff9 100644 --- a/kernel/futex/futex.h +++ b/kernel/futex/futex.h @@ -327,6 +327,11 @@ struct futex_vector { struct futex_q q; }; +extern int futex_parse_waitv(struct futex_vector *futexv, + struct futex_waitv __user *uwaitv, + unsigned int nr_futexes, futex_wake_fn *wake, + void *wake_data); + extern int futex_wait_multiple(struct futex_vector *vs, unsigned int count, struct hrtimer_sleeper *to); diff --git a/kernel/futex/syscalls.c b/kernel/futex/syscalls.c index 7234538a490d..a182ea44ea89 100644 --- a/kernel/futex/syscalls.c +++ b/kernel/futex/syscalls.c @@ -187,12 +187,15 @@ SYSCALL_DEFINE6(futex, u32 __user *, uaddr, int, op, u32, val, * @futexv: Kernel side list of waiters to be filled * @uwaitv: Userspace list to be parsed * @nr_futexes: Length of futexv + * @wake: Wake to call when futex is woken + * @wake_data: Data for the wake handler * * Return: Error code on failure, 0 on success */ -static int futex_parse_waitv(struct futex_vector *futexv, - struct futex_waitv __user *uwaitv, - unsigned int nr_futexes) +int futex_parse_waitv(struct futex_vector *futexv, + struct futex_waitv __user *uwaitv, + unsigned int nr_futexes, futex_wake_fn *wake, + void *wake_data) { struct futex_waitv aux; unsigned int i; @@ -219,6 +222,8 @@ static int futex_parse_waitv(struct futex_vector *futexv, futexv[i].w.val = aux.val; futexv[i].w.uaddr = aux.uaddr; futexv[i].q = futex_q_init; + futexv[i].q.wake = wake; + futexv[i].q.wake_data = wake_data; } return 0; @@ -295,7 +300,8 @@ SYSCALL_DEFINE5(futex_waitv, struct futex_waitv __user *, waiters, goto destroy_timer; } - ret = futex_parse_waitv(futexv, waiters, nr_futexes); + ret = futex_parse_waitv(futexv, waiters, nr_futexes, futex_wake_mark, + NULL); if (!ret) ret = futex_wait_multiple(futexv, nr_futexes, timeout ? &to : NULL); -- 2.40.1