Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <18605821-d4f1-c8e2-74eb-a91fc06d53b7@oracle.com>
Date:   Fri, 21 Jul 2023 00:00:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 8/9] selftests/ftrace: Add BTF fields access testcases
Content-Language: en-GB
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        linux-trace-kernel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Martin KaFai Lau <martin.lau@linux.dev>, bpf@vger.kernel.org,
        Sven Schnelle <svens@linux.ibm.com>,
        Alexei Starovoitov <ast@kernel.org>
References: <168960739768.34107.15145201749042174448.stgit@devnote2>
 <168960747750.34107.6104527579648222887.stgit@devnote2>
From:   Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <168960747750.34107.6104527579648222887.stgit@devnote2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUdjMWpnUURmOTRkSXlZUnNaQVhjUi9GQ0x3OEtuTDd2NzVwaTlwbnZXSDBV?=
 =?utf-8?B?Sy9BSHpJMVZ5T2JpZVgvbnFsMTMyMm9oRUhBVkt1Ym9MUTRJV29VRk1aWkJj?=
 =?utf-8?B?cVh4Z2RKS1JLUDh1UzBTS2dmRXFqakg4MFVDVFo5MURKRjZwQjF4MnFpdHRo?=
 =?utf-8?B?VUg0alJ3WE5tQzdWOTNsbEh1cFo4ZXMrZ0pVYVNaZVJ2U1VMZjJrNVdaTUhw?=
 =?utf-8?B?STJja2pzSEp0T3o2dnB2NUxuQVIwc0ZxaU1WT1QydUY0clZvT3BtQ3Q0SG5a?=
 =?utf-8?B?TWdsaGFrSlhiRklYSnIvT0FiTzdCamYxdHloZ25lK2VmdHppaTdFYWl3VHFr?=
 =?utf-8?B?YTFSMUhmV3FHK3hzbitrUTlHVGxTYW1TM3J6UlUwWVJPcjZpenU1S0szWmcz?=
 =?utf-8?B?RTMxdnNRZFliWlhSVjkyaDlSVEFKK3BwdCtkaEpmeStyN3hRak9VSDgwUzRn?=
 =?utf-8?B?TmwxZ3V0bUFpU21KSEJQTGlLZjF1NXVtZ0tqTEhBUmN1ek16VVQwOFJCSHRh?=
 =?utf-8?B?MndnUjc0V1dzTGNYVlozcC91b0dqSWxPZEliYkY5WEZkYjdqOFl1M0NORDJL?=
 =?utf-8?B?Rmo4VGhPNm9zTGEzZStWd3hhR202UWZOaWZuTFU3OUpTaE9QOWozYjJIQ2xv?=
 =?utf-8?B?YUZ4d3MzeFU1SnNCTVlzSTNpVUhSZk1nem9UYnZhN2RtU3pkKzVSakdPd2N0?=
 =?utf-8?B?S0hNWDZ3NU1lR3MvSUNXaWVPb1VCSU9TNlJkNU5IdHA5RjM4NG9mM0pWQU5p?=
 =?utf-8?B?aCt5NWF3ZVFHRCtRRExNWnpUTHR0UGJxRVlqcStoTlZVYnFoRmJqSjFCcnRD?=
 =?utf-8?B?RFc3ZW9zNlRzNkVEaUF1MnRyUk9hZ3ErL0tPWUNUVWMxOWpOMm1ZeCtMUDEv?=
 =?utf-8?B?UmY2MDJkZTBaMGprSmxLTnZqTjM2NjRLclUwOVZNWmFnMWxKL3BRdGVZRWVo?=
 =?utf-8?B?WlVKVXdFTGlPWmpCTXpXa3ljMVIwQUo3T1N1ZzB6dVhMTE91RU4yUVdpZTRt?=
 =?utf-8?B?THYrRnlzTG1SSWNhNlFtM1g2Y3pwL29jOHB1SUFIN1BjdWNCbEt6a2xwK0dB?=
 =?utf-8?B?U1d4TGZkdmt6cmNnK1JxUmYxcVJiRythem1FSS9zNGtsN1JCcTZUcjJqTzlX?=
 =?utf-8?B?SE44ODJTaWNyUlNnc0FuVnQyUjN0dmZHZkV4Y1lZQUxwLzJyeHBLRzVyUFlp?=
 =?utf-8?B?T1liam5PdWZnbVZNQm5MS2k0OVVwVjhTbklWOHAvNHJpc1N4Y1VaeFZKb0pE?=
 =?utf-8?B?VXp5VzFXN3JXOGNyRURjNFdQZWpwSTZxYnVnTXFOY3QxQ3BoejhPNWFMY3Bw?=
 =?utf-8?B?c2R6UGhkV2tHVXBnV0hWby9UcDRSZlN1Rk83cGpNMmV0djFJVHRuc2ZDVzVI?=
 =?utf-8?B?Qkx6VVdWcDZEdDNEMGZmZWZzK1ExTy83T0tPU081SmlmZUZCbTI3Yzlza21i?=
 =?utf-8?B?UVZLSE9aK3RSNHdid1h1cXpqMXdhUGtXNWhKdTRvbkRaNG9zNkRuSlo3ZzBN?=
 =?utf-8?B?ZmJxdHlIeXVkcW0zOEMvemt2Q0xUYWkrOUtJdnRLclFWUWhQTXhOMmJoTzly?=
 =?utf-8?B?RlNOejhnWGJKd3hDQUpzZUpTVjZEWW43R0dPckZzU2QyaUlsMFFLSFNZbVZW?=
 =?utf-8?B?aEhrQURaTG5PTjBFNHlBRlgxakF5OXMxZE4wOGNYa0xuQUNBSGltbFYvdmpS?=
 =?utf-8?B?MXFtNkUzYlNSakRJWjZ6ek5TRXdhS21MMEZWKzBIWm5hZDg2TU1HUVJHT09w?=
 =?utf-8?B?cDBZNjMya0VBVXJHMmhEcTAyZHhEUE94dFBqMHl6VEJ1UjQwVWNSbVg2aGhV?=
 =?utf-8?B?aUJqV0cyZDdjVGdPY1RHZ2xsRElCU2RIMDVFMnJzaGN5aHhSSDJVMm9SRGdp?=
 =?utf-8?B?SnRTa2VadStTNncvcFNlSnNCQkRwRHQ5TUlGM3VNZGZPelRmMXJZWkM5NE02?=
 =?utf-8?B?bXJYRTJ5aU5Ia2FJbC9YQk9nOTRtUWZhckxITk95VDRzUnAxNE8wOXk0VC9r?=
 =?utf-8?B?cXE1cDZDNDIyTmE3VmNFNFoxZzZiVDlJZmpJZlJwYi9xSUhhRnExemNldFhK?=
 =?utf-8?B?VDlsMklqYnhsYmFLYTVzS3B5clZwYTJWbnNodjZMUXJyTlI5cUgrbzZvS1M5?=
 =?utf-8?B?R0JwMnNUL2hRditxVXA4N1ZTL3JDdjc4eDZSOGlJVzRydFN1MDhrV0MwZEVD?=
 =?utf-8?Q?f4gNXGo7N49C5c+TTBwXK9M=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mjlaBfsudakv+1ePh/WnuRC3z3ITNC5jYfCq88xSFnzJm+MwogGq+QRcajxmE7f13vm6WOb/++S4f5PTw+kC73SsW7NRHI0CIEabAiC+M4LUec7cV7ZKuYSUBzcCsMXxo5t0rBGAbRaM73EvPuaU6kxuK1SbXycn0sDPRZWwOoSLxjmtzH/xySOZiG6M6Ce4ATObVd7tQuIRKC7qR7KwiFFQNH0f3oeNZh3/HaO4WEjefDE2C0coepIxdv04K/kAwH7C7UkxqqGIdjcUwQKDICfOqpfZ8TDOW1SlX6FSeD2QsRrRg4ZjiEKOj0Q6azH9bcJ637C7xLPvqCXGe68YD0Ze0uGbeyuWvbLz07IJcXLuaqb3hffBxNheaUwNZnYxE+mTKaYicqs2rwhqy1RIuq9PaGoyxnrjEDSRlTGRUyj8dAgavkGzYT0kfrbnGqM9hxR48ZyPz/eaZcfNpVmMAl1xVVPkNE05DyWpOiedz+RQzCe/P502ZOlPMSfIayrrKsrcfFtratRpo62S+jdO99h+xD/ccnITUXGTzikVujntMI405MKBN6SiHOk5Ez781zmX9YOGTa+lB+HL5kVbCN7Hmo0VSpgqNz6TWvPU7Lb6aFmOnaOyNf3rFtLqpRurxsKmKmd+ZuzMGcPdSx7ZR9N7kIgHHMwA0ze7iiD1zKMOi02+DPaoBq8C91S039I5OW7NWwpO8L+1P157hZAUz9NFjJosdBHd2ILO6Kjh2rnkE35NAUcqP6NBobfVxVPkj2tSBL+OeKodK0R3TbMEbJfXceKIZDB1Bo09Kjb3n4U50wkeKqQ5uW75LHw4HRwEMzVUC0GwyTP2GOpl/8ByL/385F/l3/daM3d4ywl5LkVxFKu+KjwLmvZQxzjN9zBAUrF8/yvU1CxUvnWjRLO81g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba0f78b-1103-4e15-ced8-08db8975218b
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 23:00:37.1973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2otUUkEU0vn19C8OWKhzLpjVEVsSAsIliKSH4f5k2bOkDezyOEt0Vjr13cDRxsjMX/lRA3d2BDKq2luConNKHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5820
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-20_10,2023-07-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307200196
X-Proofpoint-GUID: p6HPfhMhoJUkjf7SVIgJIRLvnlBiuUar
X-Proofpoint-ORIG-GUID: p6HPfhMhoJUkjf7SVIgJIRLvnlBiuUar
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/07/2023 16:24, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> Add test cases for accessing the data structure fields using BTF info.
> This includes the field access from parameters and retval, and accessing
> string information.
> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

One suggestion below, but

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

> ---
> Changes in v2:
>  - Use '$retval' instead of 'retval'.
>  - Add a test that use both '$retval' and '$arg1' for fprobe.
> ---
>  .../ftrace/test.d/dynevent/add_remove_btfarg.tc    |   11 +++++++++++
>  .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc |    4 ++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
> index b89de1771655..93b94468967b 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
> @@ -21,6 +21,8 @@ echo 0 > events/enable
>  echo > dynamic_events
>  
>  TP=kfree
> +TP2=kmem_cache_alloc
> +TP3=getname_flags
>  
>  if [ "$FPROBES" ] ; then
>  echo "f:fpevent $TP object" >> dynamic_events
> @@ -33,6 +35,7 @@ echo > dynamic_events
>  
>  echo "f:fpevent $TP "'$arg1' >> dynamic_events
>  grep -q "fpevent.*object=object" dynamic_events
> +
>  echo > dynamic_events
>  
>  echo "f:fpevent $TP "'$arg*' >> dynamic_events
> @@ -45,6 +48,14 @@ fi
>  
>  echo > dynamic_events
>  
> +echo "t:tpevent $TP2 name=s->name:string" >> dynamic_events
> +echo "f:fpevent ${TP3}%return path=\$retval->name:string" >> dynamic_events
> +

could we test a numeric value like kmem_cache_alloc object size?
also if combos of -> and . are allowed, would be good to test one of
those too.

> +grep -q "tpevent.*name=s->name:string" dynamic_events
> +grep -q "fpevent.*path=\$retval->name:string" dynamic_events
> +
> +echo > dynamic_events
> +
>  if [ "$KPROBES" ] ; then
>  echo "p:kpevent $TP object" >> dynamic_events
>  grep -q "kpevent.*object=object" dynamic_events
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
> index 72563b2e0812..49758f77c923 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
> @@ -103,6 +103,10 @@ check_error 'f vfs_read%return ^$arg*'		# NOFENTRY_ARGS
>  check_error 'f vfs_read ^hoge'			# NO_BTFARG
>  check_error 'f kfree ^$arg10'			# NO_BTFARG (exceed the number of parameters)
>  check_error 'f kfree%return ^$retval'		# NO_RETVAL
> +check_error 'f vfs_read%return $retval->^foo'	# NO_PTR_STRCT
> +check_error 'f vfs_read file->^foo'		# NO_BTF_FIELD
> +check_error 'f vfs_read file^-.foo'		# BAD_HYPHEN
> +check_error 'f vfs_read ^file:string'		# BAD_TYPE4STR
>  else
>  check_error 'f vfs_read ^$arg*'			# NOSUP_BTFARG
>  check_error 't kfree ^$arg*'			# NOSUP_BTFARG
> 
>