Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10206579rwp; Thu, 20 Jul 2023 16:50:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJxJJPoqODVe1GNMhj6ZQL+VhQzo3xlxo0gQejpR9xeL/EqrRsbBP1GgdvC7w/x53o+lHz X-Received: by 2002:a05:6a00:24c5:b0:666:a25b:3788 with SMTP id d5-20020a056a0024c500b00666a25b3788mr269065pfv.34.1689897039812; Thu, 20 Jul 2023 16:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689897039; cv=none; d=google.com; s=arc-20160816; b=lx7YB5apMVZUExlyisEhlh9DRju8vbXdQ4o1saZFlMwKwE7gN4D+WdeKhzb5tLA3Ts 8fLaB3KQ4hq/uIfqW73UepwUX13ATIQKzXNCXeC9t+6I5IQ4qcshOgVq7vb5a93AYiCQ B4WbXJgF691O7q4Mx92D1EM/dy7SP1FMztvPYdzBnyVFrbvd7aF5ehlnxpoNk8G3jndX NWaTQFtPnsWNm9c/hqsvy9l09/xYGfwnRGFnicvAXe2GrgGiXMr6LdCdfYUmhsY1Ro+j gAg+EWZAjnkFO+txAwK1FehPGWmlVPBmfdW/KeOQ3lsLbHNPute/6pdL2d92jUlRZxep Bt6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=j/sYUquAUvDxg4G2Pc3+UCOSl3xpWcp3XI+PCGPOJdw=; fh=6+vTJyBoxpP2pJ8+ohbyMSPnzUMzCpT0gA6QQYpgZGE=; b=b98qm7sYdjlbR+sac7aDXsqcvSqqc2AHgJtBfHZyzvOFa9RdsOKS9lJOAyRLiHD4qO P3XTLSjyVyNo6ZYS1Lt7QVqfNh9239tV12YZ7tQ2cX7xRDPw60plqB9+T1jx431HbUjI CIxd9JZHIuvYIUfyLfJSV+HqPlbcAfDGqiiNdqhbnLoEibJDv4Qa+XdiWuxvmE8wpKDH 53AsEf4Kyjy1fonzDTKLkeNpWGc12RECoVbFj6RlmdDz1lC2J1KTZeiID84cQUhXq6rw heNPdjAuCYbYqfuW7R0e3NLBrVGf0flgJgAssICf7Xs4amyx6Wc2EJK9vmvdprtc/f6u W1nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OiFhvEJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m3-20020a056a00080300b0067713a69349si1959207pfk.1.2023.07.20.16.50.28; Thu, 20 Jul 2023 16:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OiFhvEJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbjGTXdb (ORCPT + 99 others); Thu, 20 Jul 2023 19:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbjGTXdQ (ORCPT ); Thu, 20 Jul 2023 19:33:16 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07AC3272C; Thu, 20 Jul 2023 16:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689895995; x=1721431995; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MK2XOabpp0+ITG3nb9egYU4kf4/X+3sgx4FRHS80pAI=; b=OiFhvEJNwbaew7mF1TwykVV3bfDHXVA337OETK+MZnBJWhVgOhPbQTCh ntVYTvV8svkDbjXFInNSJJ+ok8UguVMLoO6j5MtCYwazv0hNE1VzWV7Kq rqfLLNWsFjH0N4e9bnSYw7e927Jx19XpdDPbjtp0ugtA4uSzP1ZekMYY7 VnOqrxXic1qQNosqQmKFOUKs2xr9s8o5zAQBE7xg14P6CAWGJlJqb3jNZ +eBROtDV+Ga+EoHAd9icwmxfJVQ6i6FDuXPV4vVU4XzFrgCBep5mUpcjC 9diYETxg5DU1hK9BZboGxDgDpgjtyGoisjlPPdummapMXMSqMdGrKFXft Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="364355943" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="364355943" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2023 16:33:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="727891796" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="727891796" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2023 16:33:12 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , Sean Christopherson , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao , Brijesh Singh , Ashish Kalra Subject: [RFC PATCH v4 06/10] KVM: x86: Export the kvm_zap_gfn_range() for the SNP use Date: Thu, 20 Jul 2023 16:32:52 -0700 Message-Id: <54a48823a690d2f44bcadd36abc3274e5368903f.1689893403.git.isaku.yamahata@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brijesh Singh While resolving the RMP page fault, there may be cases where the page level between the RMP entry and TDP does not match and the 2M RMP entry must be split into 4K RMP entries. Or a 2M TDP page need to be broken into multiple of 4K pages. To keep the RMP and TDP page level in sync, zap the gfn range after splitting the pages in the RMP entry. The zap should force the TDP to gets rebuilt with the new page level. Signed-off-by: Brijesh Singh Signed-off-by: Ashish Kalra Signed-off-by: Michael Roth Link: https://lore.kernel.org/r/20230612042559.375660-39-michael.roth@amd.com --- Changes v3 -> v4: - removed redandunt blank line Changes v2 -> v3: - Newly added --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/mmu.h | 2 -- arch/x86/kvm/mmu/mmu.c | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index ab7d080bf544..e4f2938bb1fc 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1842,6 +1842,7 @@ void kvm_mmu_slot_leaf_clear_dirty(struct kvm *kvm, void kvm_mmu_zap_all(struct kvm *kvm); void kvm_mmu_invalidate_mmio_sptes(struct kvm *kvm, u64 gen); void kvm_mmu_change_mmu_pages(struct kvm *kvm, unsigned long kvm_nr_mmu_pages); +void kvm_zap_gfn_range(struct kvm *kvm, gfn_t gfn_start, gfn_t gfn_end); int load_pdptrs(struct kvm_vcpu *vcpu, unsigned long cr3); diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h index 92d5a1924fc1..963c734642f6 100644 --- a/arch/x86/kvm/mmu.h +++ b/arch/x86/kvm/mmu.h @@ -235,8 +235,6 @@ static inline u8 permission_fault(struct kvm_vcpu *vcpu, struct kvm_mmu *mmu, return -(u32)fault & errcode; } -void kvm_zap_gfn_range(struct kvm *kvm, gfn_t gfn_start, gfn_t gfn_end); - int kvm_arch_write_log_dirty(struct kvm_vcpu *vcpu); int kvm_mmu_post_init_vm(struct kvm *kvm); diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index d2ebe26fb822..a73ddb43a2cf 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -6759,6 +6759,7 @@ static bool kvm_mmu_zap_collapsible_spte(struct kvm *kvm, return need_tlb_flush; } +EXPORT_SYMBOL_GPL(kvm_zap_gfn_range); static void kvm_rmap_zap_collapsible_sptes(struct kvm *kvm, const struct kvm_memory_slot *slot) -- 2.25.1