Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 07:43:09 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     sunran001@208suo.com, dennis@kernel.org, tj@kernel.org,
        cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC
Message-ID: <ZLnGjanv23R8O4FU@MiWiFi-R3L-srv>
References: <20230718063328.16140-1-xujianghui@cdjrlc.com>
 <7aa3a1cee63518cb13906d11ea130c9c@208suo.com>
 <20230718101735.aa31791899e2f9e19e8e0a75@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718101735.aa31791899e2f9e19e8e0a75@linux-foundation.org>
Precedence: bulk

On 07/18/23 at 10:17am, Andrew Morton wrote:
> On Tue, 18 Jul 2023 14:35:11 +0800 sunran001@208suo.com wrote:
> 
> > ERROR: function pcpu_balance_populated called on line 2238 inside lock
> > on line 2234 but uses GFP_KERNEL
> > 
> > Generated by: scripts/coccinelle/locks/call_kern.cocci
> > 
> > ...
> >
> > --- a/mm/percpu.c
> > +++ b/mm/percpu.c
> > @@ -2033,7 +2033,7 @@ static void pcpu_balance_free(bool empty_only)
> >   static void pcpu_balance_populated(void)
> >   {
> >       /* gfp flags passed to underlying allocators */
> > -    const gfp_t gfp = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN;
> > +    const gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN;
> >       struct pcpu_chunk *chunk;
> >       int slot, nr_to_pop, ret;
> 
> I don't believe this warning is correct.  

Yeah, the warning is false positive. It releases the lock when
requesting memory allocation, then take the lock again.

> 
> 			spin_unlock_irq(&pcpu_lock);
> 			ret = pcpu_populate_chunk(chunk, rs, rs + nr, gfp);
> 			cond_resched();
> 			spin_lock_irq(&pcpu_lock);
>