Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5e226fa-b314-ad04-48df-6ee17925bac6@quicinc.com>
Date:   Fri, 21 Jul 2023 10:26:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/5] soc: qcom: socinfo: add SM4450 ID
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>
CC:     <quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
        <quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
        <quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230719100135.21325-1-quic_tengfan@quicinc.com>
 <20230719100135.21325-6-quic_tengfan@quicinc.com>
 <185cb945-4c4e-1697-060e-602a3af2fe50@linaro.org>
 <3d544c17-7aa9-bc68-c56d-6b6fad1c7b66@linaro.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <3d544c17-7aa9-bc68-c56d-6b6fad1c7b66@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 7/19/2023 6:26 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:15, Dmitry Baryshkov wrote:
>> On 19/07/2023 13:01, Tengfei Fan wrote:
>>> Add the ID for the Qualcomm SM4450 SoC.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>    drivers/soc/qcom/socinfo.c         | 1 +
>>>    include/dt-bindings/arm/qcom,ids.h | 2 ++
>>>    2 files changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>>> index 4d49945b3a35..fa5e4c54207a 100644
>>> --- a/drivers/soc/qcom/socinfo.c
>>> +++ b/drivers/soc/qcom/socinfo.c
>>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>>>    	{ qcom_board_id(IPQ5312) },
>>>    	{ qcom_board_id(IPQ5302) },
>>>    	{ qcom_board_id(IPQ5300) },
>>> +	{ qcom_board_id(SM4450) },
>>>    };
>>>    
>>>    static const char *socinfo_machine(struct device *dev, unsigned int id)
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index bcbe9ee2cdaf..6201bfb1405e 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -2,6 +2,7 @@
>>>    /*
>>>     * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>>>     * Copyright (c) 2022 Linaro Ltd
>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>
>> I wonder whether a single define is copyrightable.
> 
> If you carefully choose a place, like out of order, then probably it is
> a creative work. :)
V2 patch will remove this copyrithtable.
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan