Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10380928rwp; Thu, 20 Jul 2023 20:49:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEe4vfCmHwkxLKg6aXyKUbSm7jFUiXY1qhVO4lkocnfyMJWEHkhFjVuXzqzOGbaU8goyr/3 X-Received: by 2002:a2e:4952:0:b0:2b9:48f1:b195 with SMTP id b18-20020a2e4952000000b002b948f1b195mr578518ljd.44.1689911342375; Thu, 20 Jul 2023 20:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689911342; cv=none; d=google.com; s=arc-20160816; b=jvsmJRws47e8LWFe/0CgkY+MVvT3V2SaqHiodog5k3sN3N+sRNEjBcvYzLA7zkIqwJ 0opsWITL+3wHbt8adVuHIza1SUxa1+HeMsh1VsSn8xIOWGTBDiuBdcldcAhpcBZRbco7 Kb7sFUEHMrM6gw+x/ok6gs8+9DiJZlV5mmQF3fuja5t6GB09KwpmJTaSO67HCScd25qv ntaX0n/2P0GEgmCTf6EmzgO0wiRyuKhNkLHJivC6MLn6DcPVwcqazMloBBYiG4xBVqda lv8N7iwltMllIcWdrBk3RX/NdvXtnPY4rl2hIUIdrbK8TpTNPaGoTnap/7CxCm/m47mU xXlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=jvsjAvxHLFFvDnfSTLbDgFTgrlOpy9dTxoM77KDWhyg=; fh=QIVKA4xNeYokJyKwKlWZ/6N1PkQPgq7iPIY9tNYSvYk=; b=0VVDSzIT3QdOn8gdZBpZuIPXiI7hPkD95E5S9PzBGCf+UMWmot7dXFTNluYmiG4WSo 9J9ywW55fMAj/sFkEfeO/JKvGb3mQET+NXysC9hm9/Mnf3FcQpEP9f4iwfzQMa0eOLqa 8jmElhRxYMrPeDmgyQFlLwIIY5Y+NyBfJJiZYFOXBv1rGJhZb0O2J3sugg+YtNno/43V LF81Tuvo19e1vcI18blgVRoMAnoQvCN0hOT7v66XDKMqM8oODWsrJakjDDIlr69E4RFB nQqRh+lGiRbduL7UNaSN61Dl9h6fb2Nk5AR8bgP3u6uFKOuJzYkMODGj71wvQQGsW04A J6cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=agwpxmdP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qt10-20020a170906ecea00b00997ea7d6656si1596661ejb.628.2023.07.20.20.48.38; Thu, 20 Jul 2023 20:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=agwpxmdP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbjGUDa0 (ORCPT + 99 others); Thu, 20 Jul 2023 23:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjGUDaZ (ORCPT ); Thu, 20 Jul 2023 23:30:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 985B01726; Thu, 20 Jul 2023 20:30:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 349666010E; Fri, 21 Jul 2023 03:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 84A23C433CA; Fri, 21 Jul 2023 03:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689910223; bh=UAskOFtaZ+TaZ2/xO+ZiGvJ2EWkR0CxM8zJi0SrkADU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=agwpxmdPttVsCQyM7MND/000TMAOFOo7V5oRqxEaVolkfsLcPH4CnRf7z1bCSk2kC Qfe1cngTCpiH+Y0Pr/IHoktM6seCA7KPLjTrbaD+m9gi7m9AiPOnVOIoyNab3HpMHv IrkGK3xz9riRF5qffNGkuUGFvCuj3QHDBn8c4jEGc/j3E0aR0OftNk3SwsKf7uhGfe KSEE1BlbK/kTzRSsZHXJ1vuDdXcJK6LDBwLxy/7/WJ/ZjEUH+MMpHbIjATWmjQJur3 ER9ND27Ow3EJET4FqRTNNbpYv89AuGO7iLVVzmZCrqmJnmxK0qCGJ+YtWyYx6zffkJ e9uHa6uhdUUng== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 65A00C595C5; Fri, 21 Jul 2023 03:30:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v2 0/4] nexthop: Refactor and fix nexthop selection for multipath routes From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168991022341.12176.7087140976082292516.git-patchwork-notify@kernel.org> Date: Fri, 21 Jul 2023 03:30:23 +0000 References: <20230719-nh_select-v2-0-04383e89f868@nvidia.com> In-Reply-To: <20230719-nh_select-v2-0-04383e89f868@nvidia.com> To: Benjamin Poirier Cc: dsahern@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, idosch@nvidia.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 19 Jul 2023 13:57:06 +0000 you wrote: > In order to select a nexthop for multipath routes, fib_select_multipath() > is used with legacy nexthops and nexthop_select_path_hthr() is used with > nexthop objects. Those two functions perform a validity test on the > neighbor related to each nexthop but their logic is structured differently. > This causes a divergence in behavior and nexthop_select_path_hthr() may > return a nexthop that failed the neighbor validity test even if there was > one that passed. > > [...] Here is the summary with links: - [net-next,v2,1/4] nexthop: Factor out hash threshold fdb nexthop selection https://git.kernel.org/netdev/net-next/c/eedd47a6ec9f - [net-next,v2,2/4] nexthop: Factor out neighbor validity check https://git.kernel.org/netdev/net-next/c/4bb5239b4334 - [net-next,v2,3/4] nexthop: Do not return invalid nexthop object during multipath selection https://git.kernel.org/netdev/net-next/c/75f5f04c7bd2 - [net-next,v2,4/4] selftests: net: Add test cases for nexthop groups with invalid neighbors https://git.kernel.org/netdev/net-next/c/c7e95bbda822 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html