Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec6b8d6d-6191-d760-10b2-29518010f4b4@ti.com>
Date:   Fri, 21 Jul 2023 09:09:03 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH V2] arm64: dts: ti: k3-pinctrl: Introduce debounce select
 mux macros
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Tero Kristo <kristo@kernel.org>
References: <20230619131620.3286650-1-nm@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20230619131620.3286650-1-nm@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 19/06/23 18:46, Nishanth Menon wrote:
> Introduce the debounce select mux macros to allow folks to setup
> debounce configuration for pins. Each configuration selected maps
> to a specific timing register as documented in appropriate Technical
> Reference Manual (example:[1]).
> 
> [1] AM625x TRM (section 6.1.2.2): https://www.ti.com/lit/pdf/spruiv7
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V1:
> - I have'nt picked up Krystoff's ack since the file modified is now different.
> - Changes now applied to k3-pinctrl.h instead of the ABI header that is
>   now set up to be deleted in v6.5-rc1.
> 
> V1: https://lore.kernel.org/linux-devicetree/20230308084309.396192-1-nm@ti.com/
> 
>  arch/arm64/boot/dts/ti/k3-pinctrl.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>


> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index c97548a3f42d..6004e0967ec5 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -11,6 +11,7 @@
>  #define PULLUDEN_SHIFT		(16)
>  #define PULLTYPESEL_SHIFT	(17)
>  #define RXACTIVE_SHIFT		(18)
> +#define DEBOUNCE_SHIFT		(11)
>  
>  #define PULL_DISABLE		(1 << PULLUDEN_SHIFT)
>  #define PULL_ENABLE		(0 << PULLUDEN_SHIFT)
> @@ -29,6 +30,14 @@
>  #define PIN_INPUT_PULLUP	(INPUT_EN | PULL_UP)
>  #define PIN_INPUT_PULLDOWN	(INPUT_EN | PULL_DOWN)
>  
> +#define PIN_DEBOUNCE_DISABLE	(0 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF1	(1 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF2	(2 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF3	(3 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF4	(4 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF5	(5 << DEBOUNCE_SHIFT)
> +#define PIN_DEBOUNCE_CONF6	(6 << DEBOUNCE_SHIFT)
> +
>  #define AM62AX_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))
>  #define AM62AX_MCU_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))
>  

-- 
Regards
Vignesh