Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Suman Ghosh <sumang@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [EXT] Re: [net-next PATCH V3] octeontx2-af: Install TC filter
 rules in hardware based on priority
Thread-Topic: [EXT] Re: [net-next PATCH V3] octeontx2-af: Install TC filter
 rules in hardware based on priority
Thread-Index: AQHZuTIObWsnKl/ryU6HSUdFWOHCeq/BjQwAgAIZoCA=
Date:   Fri, 21 Jul 2023 04:33:57 +0000
Message-ID: <SJ0PR18MB52169A0F0DED59ED9BA62039DB3FA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20230718044049.2546328-1-sumang@marvell.com>
 <ZLhHqn2mNP6L4qNJ@corigine.com>
In-Reply-To: <ZLhHqn2mNP6L4qNJ@corigine.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rl9kid6CJrSkoOn7xINsc2/pC0mfc/0s2Kqc3qNPUTPJj/jvDuNSqpXum/Zy?=
 =?us-ascii?Q?7OsjAtszAs6aUbtuyXoZmVEaEV5+nV0urFZDPjTuAntYdAJXpRhDntrjPOAH?=
 =?us-ascii?Q?xBqlUy4/pk0ODiQA1gGNE6lFAo9VQcB8fkymUwu47dQuwOe5NP6i+J35iYFK?=
 =?us-ascii?Q?yB8GFQLw9D/Tzdlhqpi/YPYQ62MeUH3usL7wq+uHqPoZYOOT4QptRg9Gt1ZX?=
 =?us-ascii?Q?9hV6s7VZStFMl00/mg61kDNxm4sjro2R7bHLrIKnbkwSgRdy38gFR8fr9ka4?=
 =?us-ascii?Q?433FZp/0d1viE7zbtkGsZ9QYLqCJvIXTqrJR3z22b8u8IFul0kddKvhGXxbb?=
 =?us-ascii?Q?NVDnafre+eaHU6zQdiEtL+n5K758FtLYFdv95T6uA3lGo6bbgiPoHKyhrnw0?=
 =?us-ascii?Q?466WlTJl3UDIb2GHyg3tzAHnLxzeliUmHXtdJoVjoraRHW0Qyj2hEjTS2gNx?=
 =?us-ascii?Q?L7iK99QhyAlcnBTjCIpzTZyrDTdWbLlrLjjQtQ9KzhKwrnL3muO/MZ61iw82?=
 =?us-ascii?Q?/ZMKKVtqEhc/xBXlAtVN1jKImbWX+CFwYoDPn0aje3SAKEQpT8dqAOIZwjWY?=
 =?us-ascii?Q?Q2+F5iQV+XSAn87CF+jPfjO5CX2IEEIAGGVCVgeJ0SOfnT4OTn+ufBQCvB/O?=
 =?us-ascii?Q?1Jzq7wUP3oKrT16J/qLHe5wcn8P0GAklmZk22D0cNOB0uUvf5FZwPAaYzH6V?=
 =?us-ascii?Q?8cSqHktDd3b6JnrP9k01OOONu0C+1Jhvul9hsbUTKtwqbo85wxoZJVt6DcUW?=
 =?us-ascii?Q?afAbULQqw6qapl5G0wp9ph0L5CkCLLMm4JsTGEfpBpby9gFszch2YZZBwNWd?=
 =?us-ascii?Q?aeCK4x6qxj98WTLWxCvRT5TeMBxRfQPSXebJLJ11l/TJFMVSqn9UA4dEKfrR?=
 =?us-ascii?Q?DoyR5/fhSSvZhDWerUTDQm+ojviW5Noskav6HRvR+GZSoQqH2jWg3we6H13C?=
 =?us-ascii?Q?02iRzf6zRGQmgnMFZhgH+59FGA/wf5nNPG5linPpkyM5eCgiskZsp9G41n+Y?=
 =?us-ascii?Q?xgYK46FxK1nJyTK2+fh1tIL7DGJgO/kHWr9B963Z4QAdU50kb9F7dEXIzBzh?=
 =?us-ascii?Q?IRxYq16HtIah6moqkokHISa6If4Es4qDAvC9FLHCu0fTPDf56P425cZPN5ms?=
 =?us-ascii?Q?nftHwRsxB9zOUpCafq/6M0PWDkYc6+3GNFTmHsuUT96zyySPkBdFQYKrTWSg?=
 =?us-ascii?Q?2HV7dKQb16B3Fuz5ct25L2lJvNvLAhaUXE4XjCcTNyx3hvxjI9EDJS4AWcdP?=
 =?us-ascii?Q?sh1GnTq1VM+slbcEPKcdZdXmK0En/p9k4M6KpTxeeKrMn1lowBjNNNHrOxMx?=
 =?us-ascii?Q?dhY/XWvUfyXnRsQ2RV/C+Y3/fzOdwvtVSZn1z0syZi5tEkdUTp1c0tZf+fXL?=
 =?us-ascii?Q?+MWiWziSVZGa57u7mjvQC8cSR5fxZWf/i02ASRYpeybDgtY0hr6cGLPnWIcp?=
 =?us-ascii?Q?kidZMCFLBVJbOOYVulJt2jf6WfR9k7XiAhG6H+Qh8UaKBLYWv8+9SqEqpaq4?=
 =?us-ascii?Q?BwtVquOoKwclOihVaV4xM/n1NCHlS9NjPsPgnkgHmIDUDJxZQ0nTCuRVUPFe?=
 =?us-ascii?Q?gLmpeJ7cydiuQhF+i7NNnCh2dBZJnCV/LzR2rGBs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08ea4638-cc14-46a3-7b94-08db89a3b2e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 04:33:57.6527
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 24SDL3yySDdLnPyJW36S2dfqBW47wihLbbH+TzFpV0Mr22X/vwjYFmirn8CgdgvIpDEkSPZ+e8JHV85F6qID6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB5255
X-Proofpoint-GUID: YeVHAmv9HhLkeWvBVSeN_AfFGxncmKxm
X-Proofpoint-ORIG-GUID: YeVHAmv9HhLkeWvBVSeN_AfFGxncmKxm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-21_02,2023-07-20_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>> @@ -729,22 +816,106 @@ static int otx2_del_mcam_flow_entry(struct
>otx2_nic *nic, u16 entry)
>>  		mutex_unlock(&nic->mbox.lock);
>>  		return -EFAULT;
>>  	}
>> +
>> +	if (cntr_val) {
>> +		rsp =3D (struct npc_delete_flow_rsp *)otx2_mbox_get_rsp(&nic-
>>mbox.mbox,
>> +								      0, &req->hdr);
>> +		*cntr_val =3D rsp->cntr_val;
>
>Hi Suman,
>
>otx2_mbox_get_rsp may return an ERR_PTR.
>Is it ok not to check that before dereferencing rsp?
[Suman] No, we should check for the err pointer. Thanks for pointing it out=
. Will update in v4
>
>> +	}
>> +
>>  	mutex_unlock(&nic->mbox.lock);
>> +	return 0;
>> +}
>
>...