Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 11:00:10 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     pangzizhen001@208suo.com, oliver@neukum.org, aliakc@web.de,
        lenehan@twibble.org, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi: Fix typos in comments
Message-ID: <ZLoCynrRoXHPn/Dx@debian.me>
References: <20230720160417.4434-1-wangjianli@cdjrlc.com>
 <0dbfe7a07c205bde3fc60408ce7aa55a@208suo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tUojydz+PJ84pRbC"
Content-Disposition: inline
In-Reply-To: <0dbfe7a07c205bde3fc60408ce7aa55a@208suo.com>
Precedence: bulk


--tUojydz+PJ84pRbC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 21, 2023 at 12:06:11AM +0800, pangzizhen001@208suo.com wrote:
> Delete duplicate word "the"
>=20
> Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com>
> ---
>  drivers/scsi/dc395x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c8e86f8a631e..077e76407c58 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *ac=
b,
> struct ScsiReqBlk *srb,
>          /*
>           * KG: We should wait for the DMA FIFO to be empty ...
>           * but: it would be better to wait first for the SCSI FIFO and t=
hen
> the
> -         * the DMA FIFO to become empty? How do we know, that the device
> not already
> +         * DMA FIFO to become empty? How do we know, that the device not
> already
>           * sent data to the FIFO in a MsgIn phase, eg.?
>           */
>          if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

I'd like to write the comment above instead as "We should wait for the DMA
FIFO to be empty, but it would be better to wait first for the SCSI one and
then the DMA one to be emptied..."

But hey, you did not read review comments to all your submissions, many
of them (including mine) asking you to not corrupt your patches like this
one did.

Hence NAK from me.

Bye!

--=20
An old man doll... just what I always wanted! - Clara

--tUojydz+PJ84pRbC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZLoCwwAKCRD2uYlJVVFO
o/yqAP97ZqXlHc3rrSddM5kQKqSMc3wRtFn80O0PfzXELvHAYQD+OyCOc61XP+VK
Tomz4+5hzNY6Z+K5JMDnGhtFNH/qFQo=
=TekW
-----END PGP SIGNATURE-----

--tUojydz+PJ84pRbC--