Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10464420rwp; Thu, 20 Jul 2023 22:48:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlHPpASzsIgT7vizZoUhTCh9RxaJE09aPjPGwH2CbDNQr3njmPd28L4qnyM8vq98bzvF/z6a X-Received: by 2002:a17:906:21c:b0:992:9005:8302 with SMTP id 28-20020a170906021c00b0099290058302mr736533ejd.77.1689918495955; Thu, 20 Jul 2023 22:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689918495; cv=none; d=google.com; s=arc-20160816; b=krrXIjhgaUdp3HJe7iBjDwVeuNsFCr4LXkaIcbfQwQQlOfEXmP5QsY1/sYdsTk1I4f 5ZczZx9mvuDBYrOdbl9JrlVP0QNhBuYH3B8aikXgjAHkUa63NKzzjjWVxLY/SXTAplR8 viSqKIh1d24YJz8zEq0imGHh98/OvzmWKu7SJ8vRPmRbeGvrQs1fvrc9C16fSXlQHNEa kc5wA6aJoqyBBCX8a/logR8s2/X4S8aWimhPUvUP0A+v0kOuKeURXnLLMDAQtYfxzchP hVs1+7XTOFlRGaY2tvtp2UIlW0f49f6v8TH+VAc29loZD2ujZl4Gp0udxnTi5WuQWepP 4/Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=deH+1deCDlkwheLCVKxsVerkOkZdzWfKq1Au0npBzMo=; fh=2VcjBvmaWbXqMQ6RDjrhIUzWXqIDtGQMMQQKK/GSfS8=; b=QjAvjuGiF9WePinoJfSbjM2oUtYA9h0m+qiMhyE2yoomlGViL7OprCRLQjx6DINspR PN+kCKrQ0ubneMOm4mKHm76Y3vctBB/EOEtCsgtBduO96ASkMs7tGdqyVWxz27YV1yJq 1UC4iGx69Qjb4STCoXPNQ9Z9O3wh6VdUvzQ9OlhLG8XrUj5ZN4Ya4ojZERUHhuZGRTGW PoqD4VLb9Pgur2/ZrdAQQUDNUbjs5gzKEy/LqLsrEk2zFwg+nRQliVjl90fP4qkn4bOA 3YojWIYzU/oUswe89MicVwe0jD38ZosJdYaqMgDRN7KDf0PlmiLPyYBIKvGHde7y6AWO trfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a170906a38c00b00991bd84725asi1645339ejz.227.2023.07.20.22.47.51; Thu, 20 Jul 2023 22:48:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbjGUFnh (ORCPT + 99 others); Fri, 21 Jul 2023 01:43:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbjGUFna (ORCPT ); Fri, 21 Jul 2023 01:43:30 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A96A1984; Thu, 20 Jul 2023 22:43:29 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3ED6A80BA; Fri, 21 Jul 2023 05:43:28 +0000 (UTC) Date: Fri, 21 Jul 2023 08:43:26 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative Message-ID: <20230721054326.GO5194@atomide.com> References: <20230720051021.14961-1-tony@atomide.com> <20230720051021.14961-2-tony@atomide.com> <2023072022-country-replace-68ca@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023072022-country-replace-68ca@gregkh> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg Kroah-Hartman [230720 19:33]: > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote: > > The controller id cannot be negative. > > > > What does this mean for a changelog? Just let's fix it while at it and adding port_id in the following patch. If you prefer I can squash the change into the fix adding port_id. > And you forgot to cc: linux-serial? > > And I never got patch 0/3? > > something went wrong here... Thanks for letting me know, I'll check what went wrong.. > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > > Reported-by: Andy Shevchenko > > Closes: https://lore.kernel.org/linux-serial/ZLd154hdaSG2lnue@smile.fi.intel.com/#t > > This isn't a bug report to close, is it? OK will leave it out. I added it as checkpatch.pl now warns if Reported-by is added without Closes. Regards, Tony