Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 14:27:35 +0800
From:   Alina Yu <alina_yu@richtek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <alina_yu@richtek.com>
Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
Message-ID: <20230721062735.GA9068@linuxcarl2.richtek.com>
References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com>
 <1689758686-14409-2-git-send-email-alina_yu@richtek.com>
 <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org>
 <20230720080728.GA10433@linuxcarl2.richtek.com>
 <fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

Hi,
Krzysztof:

> > ...
> > 
> >>> +
> >>> +          regulator-mode:
> >>> +            enum: [0, 1]
> >>> +            description:
> >>> +              describe buck initial operating mode in suspend state.
> >>
> >> There is no such property on this level. Aren't you mixing initial one?
> > 
> > It's the initial mode in suspend-mem state, should I modify that like this ?
> >         patternProperties:
> >           "^regulator-state-(standby|mem|disk)$":
> > 	    type: object
> > 	    $ref: regulator.yaml#
> > 	    properties:
> > 	      regulator-mode:
> > 	        enum: [0, 1]
> > 		description:
> >                   describe byck initial operating mode in suspend state.
> 
> Please check how other bindings do it.
>

If I modify that like this, will it be correct ?


...
          regulator-state-mem:
	    type: object
	    $ref: regulator.yaml#
	    properties:
	      regulator-mode:
	      description:
	        describe buck initial operating mode in suspend state.
		0 - Auto mode
		1 - FCCM

Best regards,
Alina