Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10508483rwp; Thu, 20 Jul 2023 23:39:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdo2N4FRW5Kz1fxCOkTHerdFtLhf2N0B5b/QBFCDfw+9hlIyU9uAZP6PQLeo9lkI5aVS7f X-Received: by 2002:a05:6a00:a90:b0:668:8705:57cf with SMTP id b16-20020a056a000a9000b00668870557cfmr1325262pfl.25.1689921592806; Thu, 20 Jul 2023 23:39:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689921592; cv=none; d=google.com; s=arc-20160816; b=W4grq4CBp7P1qvVIUEQ/SZrj4AZtlARowv/Rrr9BgYsqKScivaL7eGSERPtFNk0Qwg YBKvsTSTHlpOVgoRcz8Xl7VrvLhwMgae4YNpzVwxNlU1O7sUhi31KfsRlDOkci1wX+mJ KVCBkL3nAzTotR6fD8Kcgvv8WiM4oo+LocyCtXNz8H432X1WwIbuI6kW3tTK+n3VSDo8 3zCn6DSHo40lNubASqIkrOXp4gZ95JrXVBCzRH9GtLKONcJSWlqMV9cPqj1J7McDbzAi nl9WeDLSsefTLKS3seJSj7uqivXWJZNIpVTOw9wq39uvzcUGrX5kJCP/0TUUlVfLWXy+ yMjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1AFeXau7SdX8sTtNDalqkXtMWOURRmOvwd+fjWGHRmI=; fh=2VcjBvmaWbXqMQ6RDjrhIUzWXqIDtGQMMQQKK/GSfS8=; b=TSVUNRCm5iqTacOizQRv8/AoWs6AzGowFkl5ii9wTE+blvOYmEdQ8gThrDJNFo23aQ xpijzprAG8Rs3wszLgeBuYKqDOesMk9lCZmWDgn836zlbRA/rLPcIfbFYtAsGYYMBeHB cFCmKBfwYFtvGo4zo5t2g4slLL439pSKcdnn/44f8WKEc+vuMT70Z0dOxHKUgFz3Y8Y0 JnycMBS+lIbwDFSfupLYu2ECjLGWeWYmLhnmaju6zJb0q+E45yU5UX7SCPtyab7Yh2iA 2Hx6EUIrsPAd7yJKGxk0/c3FYG4N1fQTxdc69GI80myuPA1CnRoXzfivBeWBo6xKqqJO AJhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a63954d000000b0055b2c94e7b1si2273852pgn.190.2023.07.20.23.39.40; Thu, 20 Jul 2023 23:39:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230461AbjGUGS7 (ORCPT + 99 others); Fri, 21 Jul 2023 02:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231485AbjGUGSd (ORCPT ); Fri, 21 Jul 2023 02:18:33 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D02C349C7; Thu, 20 Jul 2023 23:15:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4463A80BA; Fri, 21 Jul 2023 06:15:25 +0000 (UTC) Date: Fri, 21 Jul 2023 09:15:23 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative Message-ID: <20230721061523.GP5194@atomide.com> References: <20230720051021.14961-1-tony@atomide.com> <20230720051021.14961-2-tony@atomide.com> <2023072022-country-replace-68ca@gregkh> <20230721054326.GO5194@atomide.com> <2023072144-splurge-debate-e681@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023072144-splurge-debate-e681@gregkh> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg Kroah-Hartman [230721 06:00]: > On Fri, Jul 21, 2023 at 08:43:26AM +0300, Tony Lindgren wrote: > > * Greg Kroah-Hartman [230720 19:33]: > > > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote: > > > > The controller id cannot be negative. > > > > > > > > > > What does this mean for a changelog? > > > > Just let's fix it while at it and adding port_id in the following patch. > > If you prefer I can squash the change into the fix adding port_id. > > A separate patch like this is fine, just properly document it please :) OK will do. Looks like linux-serial not getting added is caused by MAINTAINERS not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This causes get_maintainer.pl to not show linux-serial for a patch touching serial_base_bus.c.. And this will causes git send-email to not pick up linux-serial.. I'll send a patch for MAINTAINERS file too. Regards, Tony