Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10529044rwp; Fri, 21 Jul 2023 00:06:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlHfNYOVQSxrDZPYh0tVtRGhxLtWl1CLXaou0rWKJM3mxJiN2mdYSOT9yP8wuf1+78wY74n7 X-Received: by 2002:a05:6e02:1d9a:b0:348:90c2:ba0a with SMTP id h26-20020a056e021d9a00b0034890c2ba0amr1239403ila.32.1689923216637; Fri, 21 Jul 2023 00:06:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689923216; cv=none; d=google.com; s=arc-20160816; b=HXMlQOdpWJCeTWpzCG7lNngOPugTm9//p7S7tUEc1aIIVAKBVUgR0p4UrCqYQrFfcy OTNg8dgqqUFjZ9ho4p/cs/62uzwSuCWJMzYGffuskWeLaHjpBxn5ios0Lx9dwnrV2UlS 8f7Q9D26u5bKKII7PC7XomcguykHOiwTIEnbmCuYYcGWbt3FGyVxYTplsTkx3mehEtZT Lj1BBZAngtSEX4rt3dX67rJkDwgx2FSesxv0t6xRiHJrbsXQ2SXngbKzk7PHEo3SewOr uE1ZzaDA4B6PyE9dPqnqsKbt8QMS73v+ucbKxU2kld/OmD4PS3srMQSCg978Nqll1sPB dcqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9aLV2SEVbfjUI9alWZzR1TGP+HqucniCNpoaIznlxUg=; fh=PPVnYfGGaru6OozbKTYqx64Yor8niCUgyrMFKbMGdUw=; b=lrbQ+xtV6pYhX6Z6e0OtXUUlxhiFiQfFS+KkSFuJElbzOgQ/JM3HR0ID/biXeTiemN t9u33Ashx3YjwPWJnaLB5eH4XX6P4XqGgJTcmICOrsl+Ewh8StldN921k+19JD7O8SC0 LsD2ZtorUo1ZM05FzWO3UDtczAlmjVvRfhrKje0N2JRW0MtLRmqt+rceBHgAdPIH0SLJ DmA89hyFuyifzM2dNyV+M8tyE6GuEn/YUT3aJviad7Zx4NFsFkFHljZPtMr4poz3jIIO +fYCNPL5C6Vt2fO+77a67SJuGC2sUfazmoGWzjOkFWceS8BB99dou0cLmc8fvwwtrv7S 4YzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id by9-20020a056a00400900b0065caa80ad8csi2416578pfb.398.2023.07.21.00.06.44; Fri, 21 Jul 2023 00:06:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbjGUG0G (ORCPT + 99 others); Fri, 21 Jul 2023 02:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbjGUG0E (ORCPT ); Fri, 21 Jul 2023 02:26:04 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE24A1984; Thu, 20 Jul 2023 23:26:02 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 7D6C168AA6; Fri, 21 Jul 2023 08:25:59 +0200 (CEST) Date: Fri, 21 Jul 2023 08:25:58 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD Message-ID: <20230721062558.GB20845@lst.de> References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-7-hch@lst.de> <80507f03-86b4-6406-5ab1-5687b6d12d93@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80507f03-86b4-6406-5ab1-5687b6d12d93@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 05:53:52PM +0200, Hannes Reinecke wrote: > Can we modify this to not have a compile-time option but rather a setting > somewhere? EG kernel option or flag in struct address_space? Modify what? The current code diables buffer_head suport on the block devices when the kernel does not support buffer_heads. There is no good way to make that a run time decision :)