Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230720131028.3730704-1-james.hilliard1@gmail.com>
 <20230720131028.3730704-2-james.hilliard1@gmail.com> <CAOMZO5BPadhvTux-YMRZtZS=QaQhk9z+h7COk7_5S4gaqeE2eQ@mail.gmail.com>
In-Reply-To: <CAOMZO5BPadhvTux-YMRZtZS=QaQhk9z+h7COk7_5S4gaqeE2eQ@mail.gmail.com>
From:   James Hilliard <james.hilliard1@gmail.com>
Date:   Fri, 21 Jul 2023 01:05:13 -0600
Message-ID: <CADvTj4rrodFreH4gsYC0fW94e=+Z7m6N_2HoQDEbkc=VVKyOfw@mail.gmail.com>
Subject: Re: [PATCH v3 2/4] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM support
To:     Fabio Estevam <festevam@gmail.com>
Cc:     devicetree@vger.kernel.org,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        Tim Harvey <tharvey@gateworks.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        Li Yang <leoyang.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 20, 2023 at 7:27=E2=80=AFAM Fabio Estevam <festevam@gmail.com> =
wrote:
>
> On Thu, Jul 20, 2023 at 10:10=E2=80=AFAM James Hilliard
> <james.hilliard1@gmail.com> wrote:
>
> > +       reg_audio: regulator-audio {
> > +               compatible =3D "regulator-fixed";
> > +               regulator-name =3D "tlv320aic3x-supply";
> > +               enable-active-high;
>
> enable-active-high should only be used when there is a corresponding
> gpio property.
>
> > +&ecspi3 {
> > +       fsl,spi-num-chipselects =3D <1>;
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_ecspi3>;
> > +       cs-gpios =3D <&gpio4 24 GPIO_ACTIVE_HIGH>;
>
> This should be ACTIVE_LOW instead.
>
> > +       status =3D "okay";
> > +};
> > +
> > +&fec {
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_enet>;
> > +       phy-mode =3D "rgmii";
> > +       phy-reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>;
>
> This is a deprecated property.
>
> The recommendation is to add a mdio node with:
>
> reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>;
> reset-assert-us =3D <10000>;
>
> Is this an Atheros AR8031 PHY. If so, please check imx6qdl-sabresd.dtsi.

Hmm, the datasheet appears to indicate it uses a KSZ9031RN ethernet phy.

Would that be a different configuration vs the Atheros AR8031 PHY?

>
> > +&ssi2 {
> > +       fsl,mode =3D "i2s-slave";
>
> This is unused, drop it.
>
> Please check commit ece1e4999 606 ("ASoC: fsl_ssi: Remove unneeded
> 'i2s-slave' property")
>
> > +&usdhc3 {
> > +       pinctrl-names =3D "default", "state_100mhz", "state_200mhz";
> > +       pinctrl-0 =3D <&pinctrl_usdhc3>;
> > +       pinctrl-1 =3D <&pinctrl_usdhc3_100mhz>;
> > +       pinctrl-2 =3D <&pinctrl_usdhc3_200mhz>;
> > +       bus-width =3D <4>;
> > +       vmmc-supply =3D <&reg_wl18xx_vmmc>;
> > +       non-removable;
> > +       wakeup-source;
> > +       keep-power-in-suspend;
> > +       cap-power-off-card;
> > +       #address-cells =3D <1>;
> > +       #size-cells =3D <0>;
> > +       status =3D "okay";
> > +
> > +       wifi: wifi@0 {
> > +               compatible =3D "ti,wl1835";
> > +               reg =3D <2>;
>
> @0 and reg =3D <2> do not match.