Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10547686rwp; Fri, 21 Jul 2023 00:32:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlEf/7AxSbEomCn7P75kiJz0lXA9A61QIFdgqZ3D8ibML+wp+HRALkqTcig1I4HwZp/MmJu7 X-Received: by 2002:a05:6402:10d4:b0:51a:5c1d:5c06 with SMTP id p20-20020a05640210d400b0051a5c1d5c06mr734505edu.42.1689924729812; Fri, 21 Jul 2023 00:32:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689924729; cv=none; d=google.com; s=arc-20160816; b=bvaHkKQeH2uXwJj45+YHAb8MqP5tSmZx3hgImM3xeiYOqK4BasUCvaSvaox7tE3SU8 kbFJ970DZWgn96pLih/e7cAOtulcZsHu/DcSpgXjqWwrxS/nb388XeoMWHR0lygZq1Ho xrSKf3qCHH8oW5OpPPm35VJYLajQILBKndjFM1zSaFguY+4bP8NChDciK3YDWQiW5cQP EdlDCrTscgeIVAiUFTy05Ug+K0A0VC1tY+TqLKyOpAUUMzIvDloMGao1h5xQsLvSGFmh 7xPoWdrxGrtYYsYZxHwxNRfOpJduwtGTibPGexwXLtejk0oP+zCZe5QdSXS0LsGW9JO4 ZVNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=h5WW/aGUynkQQ7aQkCzzOC+K2kUmhVWZ/mm+JD3SdMo=; fh=2VcjBvmaWbXqMQ6RDjrhIUzWXqIDtGQMMQQKK/GSfS8=; b=QZNPJAd6VaOlUynpdrsN9MJgRBrrrwMO9zPO9RzecOKFD84Spp0BnRnepX+EpA7Ekc nx2hAQqNPgd7DsVybvNqN0mogSMMnUatlappGQbpzLhBAFUBQcQzhLfeedD20Hj4qWor 5LajSjFxe/ah8bPZU54NjMGkkTlVTv0dmeqouiik+XeRg8sPki0prXs8Gp98CANSIJMG peAz+9iLAqMdiYMzlnqUHYJ/vbBVRecWu+qBgbVxckOaLrdKQ4CWhBW+8wq+PfABhhbF RndLuG9CpL0svprESY6Utfxps5O8zVdwrZN9qW69oqmckO/7PwHE6zYDCWPL68768bcf 3JAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020aa7d446000000b00521d13de7fcsi1921787edr.491.2023.07.21.00.31.45; Fri, 21 Jul 2023 00:32:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbjGUHSD (ORCPT + 99 others); Fri, 21 Jul 2023 03:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbjGUHR4 (ORCPT ); Fri, 21 Jul 2023 03:17:56 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFC65FC; Fri, 21 Jul 2023 00:17:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2DC71807E; Fri, 21 Jul 2023 07:17:55 +0000 (UTC) Date: Fri, 21 Jul 2023 10:17:53 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative Message-ID: <20230721071753.GR5194@atomide.com> References: <20230720051021.14961-1-tony@atomide.com> <20230720051021.14961-2-tony@atomide.com> <2023072022-country-replace-68ca@gregkh> <20230721054326.GO5194@atomide.com> <2023072144-splurge-debate-e681@gregkh> <20230721061523.GP5194@atomide.com> <20230721065701.GQ5194@atomide.com> <2023072109-fidelity-modular-4074@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023072109-fidelity-modular-4074@gregkh> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg Kroah-Hartman [230721 07:07]: > On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote: > > * Tony Lindgren [230721 06:19]: > > > Looks like linux-serial not getting added is caused by MAINTAINERS > > > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This > > > causes get_maintainer.pl to not show linux-serial for a patch touching > > > serial_base_bus.c.. And this will causes git send-email to not pick up > > > linux-serial.. I'll send a patch for MAINTAINERS file too. > > > > And the TTY LAYER is missing the list entries.. Does something like below > > make sense to you guys to include lkml and linux-serial for TTY LAYER? > > > > Regards, > > > > Tony > > > > 8< --------------------- > > diff --git a/MAINTAINERS b/MAINTAINERS > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/ > > TTY LAYER > > M: Greg Kroah-Hartman > > M: Jiri Slaby > > +L: linux-kernel@vger.kernel.org > > +L: linux-serial@vger.kernel.org > > S: Supported > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > > F: Documentation/driver-api/serial/ > > F: drivers/tty/ > > +F: drivers/tty/serial/serial_base.h > > +F: drivers/tty/serial/serial_base_bus.c > > F: drivers/tty/serial/serial_core.c > > +F: drivers/tty/serial/serial_ctrl.c > > +F: drivers/tty/serial/serial_port.c > > F: include/linux/selection.h > > F: include/linux/serial.h > > F: include/linux/serial_core.h > > -- > > 2.41.0 > > Seems sane to me, I've always wondered why some serial patches didn't > end up on the linux-serial list. OK will send. Also I noticed that using git send-email --cc-cover does not work for the cover letter.. It tries to use the first patch that is the cover letter or something like that. I'm going back to my custom email scripts for now rather than try to have git handle things automagically. Regards, Tony