Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10560315rwp; Fri, 21 Jul 2023 00:50:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlE1YjE5tRPEJe40OqtDl4ONAlJldZ2VcICC0MzePbRYjCHm7QdZSUH7fPnVueqX93qt0rGw X-Received: by 2002:a05:6a00:1509:b0:668:9dca:13ac with SMTP id q9-20020a056a00150900b006689dca13acmr1310884pfu.7.1689925814026; Fri, 21 Jul 2023 00:50:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689925814; cv=none; d=google.com; s=arc-20160816; b=wiJI9R3YdlgBCcoe3HUG8rwAN27Gz4RikdXBYn+zqtzp4qSzEjvvXV1mQRO3JFNv4i AKxa1NLeypj2vtKTKaYcBe0v06OP+9tu4rn/AUkix7TJTHU6ZgpVKFCzVoXIvjEf8z/L HC6pN9BWGVTiUsIbeiWlP7QKkOlaI6k2SuFgE8l8OxV5B0ouGONZhikNRilsYjm4EN4S fvNi4mgu+i+h3QgbLwbn7ejt2Fhbjhwhi9OHDW4rXS/iZrhp2Gohe9yvk02kC1vd5t6J J3vD3C6a7DiGTuwx4hyhptcuGvW+t3lnUkDWEL/rSqLJMdwzjuO8LiqqroWgRCGeN+iZ PHzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=dJVxQOdrvO7cbea4hc+vrBFGY1P6QkJfrEqbvy2Szs4=; fh=FA6ePB5qaQomILOxean7/aeC0yiLQTvA2tKVpPqChRo=; b=etPuq0RAb97Pp6GwYSIHNQ6N6BFVfaIf7xrYfoqsKJ5UPk2L0CZMzVf16g/q3NotTx +qVlqFW9GNwElfi7JjDiq0aLWdo/BEJYfn1oNy6wpApOm/Z6+xKBnHKJQpp0QDETMKLn 6AL2lO9XpwxIIRsVhCHBV326T4LV8Gs2V5dvKBFZ9n7Wkygjggf73oSQQ86rQ28IOC8k RG4n1kzlxKJTgeF/gyn4LpAKzVzSyDDFWsHvl5NRioxK6g19SPomqI6PAe5QsDuB9VnV YcEZS4ceMRPdLojGbwWS0cT2/E0PkxkWFmbY4yNUOlitpPJJELpOp0m9544t5Se1Vegw mzGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a65670e000000b0055c8fd5fe90si2419060pgf.631.2023.07.21.00.50.01; Fri, 21 Jul 2023 00:50:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbjGUHWW (ORCPT + 99 others); Fri, 21 Jul 2023 03:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbjGUHWQ (ORCPT ); Fri, 21 Jul 2023 03:22:16 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2067730DB; Fri, 21 Jul 2023 00:22:10 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 082ED807E; Fri, 21 Jul 2023 07:22:07 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Cc: Andy Shevchenko , Dhruva Gole , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH v3 1/3] serial: core: Controller id cannot be negative Date: Fri, 21 Jul 2023 10:21:40 +0300 Message-ID: <20230721072147.59121-2-tony@atomide.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230721072147.59121-1-tony@atomide.com> References: <20230721072147.59121-1-tony@atomide.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The controller id cannot be negative. Let's fix the ctrl_id in preparation for adding port port_id to fix the device name. Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") Reported-by: Andy Shevchenko Signed-off-by: Tony Lindgren --- include/linux/serial_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -459,7 +459,7 @@ struct uart_port { struct serial_rs485 *rs485); int (*iso7816_config)(struct uart_port *, struct serial_iso7816 *iso7816); - int ctrl_id; /* optional serial core controller id */ + unsigned int ctrl_id; /* optional serial core controller id */ unsigned int irq; /* irq number */ unsigned long irqflags; /* irq flags */ unsigned int uartclk; /* base uart clock */ -- 2.41.0