Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10564704rwp; Fri, 21 Jul 2023 00:56:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlGTpq/skwBQh52qKs1zRjUrvU5uJlnvks5hNA1RYBsQ5OzFU9NmcIgl2+oAUNZw2sKA7ZdL X-Received: by 2002:a05:620a:2697:b0:767:3fa7:2afa with SMTP id c23-20020a05620a269700b007673fa72afamr1190435qkp.28.1689926187049; Fri, 21 Jul 2023 00:56:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689926187; cv=none; d=google.com; s=arc-20160816; b=ZfAv+UhC9p6fjhFZOnnwL/pu53RwXbrSPLrtpqceQgPE+XT1uBbzOXdyb/DIzmx0PB fnv0y/86JwrcjSqdXCPfXgFep39tP8GMnbTFPS0NNYQti5Bh6BaEBY0GIheckbikuLdL /Ttz3fMrdX9zKJq+/Cm4mIQ4gXrcqehEtjnhDEVBhkTFw14t916A8pRr1baScf4yVeBI o4cPYAv7PPfTJ/iBaEm1Pa0tXN1VvLORRgDft67rAweEWslQmwMPNgIn9yizEr4joA/W Ize8fn2fLMpdZ5d5QbMrZN8OjKCMJsbBYCiqNV26/FEf/LMZf/7inOw0n1L0X4/hMDyV sn0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=S6DHHezetXuYiiPkMjsDD5fTroDrw06NfY+OaRpHxEA=; fh=etoAlGBf+SpQVMMXCJMV93r+UgAwMbRgi3zaVOqfdoA=; b=YHqAfezcpo5v8HD8WuBls0dZTFU9lLm+GMb4Y9pJVqUc8Z6t6m/0gKCuWhq+y5IfC6 fh2u/MoQpIVxu+ZYtvmG1711Yadtcy3cUAmYwUpYWxGFJZ4v/+Jwj68wv+t/pPF1/qVN pYRFvKUtOOgI0PiLrx0dNt95psa5O3sxNAXlBLs/nQ7xJsaAX4/dcmoH89oyExq5s+gC ogubw1loH9Be4pPdV6YxbORkAP4tz7ZLX9jSFSqitaPud6HqK7/8E37nHtS23qvVZ8no tov/+ZYwsxHP7UNjr9G3hD5iEcrI07t8rufcqkWG5fzHNRSxR5niYHfAyoDQ5T2s87Uj 2rcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob15-20020a17090b390f00b00263542b45a4si2951228pjb.43.2023.07.21.00.56.06; Fri, 21 Jul 2023 00:56:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbjGUHJf (ORCPT + 99 others); Fri, 21 Jul 2023 03:09:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjGUHJb (ORCPT ); Fri, 21 Jul 2023 03:09:31 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D4E2710 for ; Fri, 21 Jul 2023 00:09:28 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R6gZf0J1PztRTg; Fri, 21 Jul 2023 15:06:18 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 15:09:26 +0800 From: Kemeng Shi To: , , , CC: Subject: [PATCH v2 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set Date: Fri, 21 Jul 2023 23:09:57 +0800 Message-ID: <20230721150957.2058634-3-shikemeng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230721150957.2058634-1-shikemeng@huawei.com> References: <20230721150957.2058634-1-shikemeng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded pageblock_end_pfn if no_set_skip_hint is set. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index c0d8d08fc163..9b7a0a69e19f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) { struct zone *zone = cc->zone; - pfn = pageblock_end_pfn(pfn); - /* Set for isolation rather than compaction */ if (cc->no_set_skip_hint) return; + pfn = pageblock_end_pfn(pfn); + if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC && -- 2.30.0