Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d65e25da75142b7414cbf082c7f485464b82b6d1.camel@gmail.com>
Subject: Re: [PATCH v1 0/8] iio: core: A few code cleanups and documentation
 fixes
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>
Date:   Fri, 21 Jul 2023 10:06:05 +0200
In-Reply-To: <20230720205324.58702-1-andriy.shevchenko@linux.intel.com>
References: <20230720205324.58702-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:
> Just set of almost unrelated to each other cleanups against IIO
> core implementation.
>=20
> The positive LoCs diffstat due to first patch that adds a lot of
> documentation for the new added macro.
>=20
> Andy Shevchenko (8):
> =C2=A0 iio: core: Add opaque_struct_size() helper and use it
> =C2=A0 iio: core: Use sysfs_match_string() helper
> =C2=A0 iio: core: Switch to krealloc_array()
> =C2=A0 iio: core: Use min() instead of min_t() to make code more robust
> =C2=A0 iio: core: Get rid of redundant 'else'
> =C2=A0 iio: core: Fix issues and style of the comments
> =C2=A0 iio: core: Move initcalls closer to the respective calls
> =C2=A0 iio: core: Improve indentation in a few places
>=20
> =C2=A0drivers/iio/industrialio-core.c | 226 ++++++++++++++++-------------=
---
> =C2=A01 file changed, 115 insertions(+), 111 deletions(-)
>=20

Neat series... Just a few comments on my side and on patch 3 is up to you t=
o
take the comments or not.

With my comment addressed on patch 2:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>
=20